From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Maxim Korotkov <korotkov.maxim.s@gmail.com>
Cc: Boris Brezillon <bbrezillon@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Hector Palacios <hector.palacios@digi.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: Re: [PATCH] mtd: rawnand: hynix: fixed typo
Date: Mon, 25 Mar 2024 17:41:33 +0200 [thread overview]
Message-ID: <ZgGbLe4XTy1FUP0C@smile.fi.intel.com> (raw)
In-Reply-To: <20240313102721.1991299-1-korotkov.maxim.s@gmail.com>
On Wed, Mar 13, 2024 at 01:27:20PM +0300, Maxim Korotkov wrote:
> The function hynix_nand_rr_init() should probably return an error code.
> Judging by the usage, it seems that the return code is passed up
> the call stack.
> Right now, it always returns 0 and the function hynix_nand_cleanup()
> in hynix_nand_init() has never been called.
>
> Found by RASU JSC and Linux Verification Center (linuxtesting.org)
> Fixes: 626994e07480 ("mtd: nand: hynix: Add read-retry support for 1x nm MLC NANDs")
>
> Signed-off-by: Maxim Korotkov <korotkov.maxim.s@gmail.com>
FWIW, the tag block shouldn't have blank lines.
--
With Best Regards,
Andy Shevchenko
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2024-03-25 15:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 10:27 [PATCH] mtd: rawnand: hynix: fixed typo Maxim Korotkov
2024-03-15 11:23 ` Miquel Raynal
2024-03-15 11:45 ` Maxim Korotkov
2024-03-15 12:14 ` Miquel Raynal
2024-03-25 10:18 ` Miquel Raynal
2024-03-25 10:20 ` Miquel Raynal
2024-03-25 15:41 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgGbLe4XTy1FUP0C@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=bbrezillon@kernel.org \
--cc=hector.palacios@digi.com \
--cc=korotkov.maxim.s@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=lvc-project@linuxtesting.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).