Re: NAND parameter page read fails with bitflip and no column change support

From: Steven Seeger <steven.seeger@flightsystems.net>
To: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Cc: "ada@thorsis.com" <ada@thorsis.com>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	"richard@nod.at" <richard@nod.at>
Subject: Re: NAND parameter page read fails with bitflip and no column change support
Date: Wed, 10 Apr 2024 18:45:58 +0000	[thread overview]
Message-ID: <DM6PR05MB4506C6DFD7ED777C5896B83BF7062@DM6PR05MB4506.namprd05.prod.outlook.com> (raw)
In-Reply-To: <mailman.25709.1712772710.1280.linux-mtd@lists.infradead.org>

>I had reached out to Miquel privately with this issue, only due to the desire to
>help inform maintainers of the issue. I was too busy at the time to join the list
>and write up something more formal. Miquel provided a small patch for me
>that did not work at the time, and then I lost access to the board for a while.
>Now I have a little time and a board, so I am here to report the issue and make it public.

I tried the patch from Miquel back in February and it works correctly with 6.6.12
and my older driver without column change support.

Here is h is patch for reference:

--- a/drivers/mtd/nand/raw/nand_base.c
+++ b/drivers/mtd/nand/raw/nand_base.c
@@ -2123,7 +2123,7 @@ EXPORT_SYMBOL_GPL(nand_reset_op);
 int nand_read_data_op(struct nand_chip *chip, void *buf, unsigned int len,
                      bool force_8bit, bool check_only)
 {
-       if (!len || !buf)
+       if (!len || (!check_only && !buf))
                return -EINVAL;
 
        if (nand_has_exec_op(chip)) {

I also realize that company email using outlook 365 is terrible for lists and list
etiquette. Hopefully the list handles threading from digest emails correctly.

Thanks,
Steven
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
