From: Marek Vasut <marex@denx.de>
To: Michael Walle <michael@walle.cc>, u-boot@lists.denx.de
Cc: Hai Pham <hai.pham.ud@renesas.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Jagan Teki <jagan@amarulasolutions.com>,
Johann Neuhauser <jneuhauser@dh-electronics.com>,
Simon Glass <sjg@chromium.org>,
Takahiro Kuwano <Takahiro.Kuwano@infineon.com>,
Venkatesh Yadav Abbarapu <venkatesh.abbarapu@amd.com>,
Vignesh R <vigneshr@ti.com>,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: spi-nor: Clear Winbond SR3 WPS bit on boot
Date: Wed, 15 May 2024 16:55:29 +0200 [thread overview]
Message-ID: <515848c8-65e3-41de-8a2c-af1c9e5351f1@denx.de> (raw)
In-Reply-To: <CZMOLX07WDHJ.36M7NNZK94F99@walle.cc>
On 3/6/24 1:55 PM, Michael Walle wrote:
> Hi,
>
> On Wed Mar 6, 2024 at 3:56 AM CET, Marek Vasut wrote:
>>> I'd argue if one wants to use the locking at all, you have to set
>>> UNLOCK_ALL=n. Otherwise, the bootloader might come alone and just
>>> clear your locking bits again. Clearing the WPS bit there is just
>>> one more thing which IMHO doesn't make much sense.
>>
>> On the other hand, if UNLOCK_ALL=y is supposed to work and reset
>> locking, then the SR3 WPS bit has to be configured to select the
>> standard SPI NOR locking scheme, so the locking can actually be reset
>> using that scheme.
>
> Yes, that's what I've meant with "the unlock all works as
> advertised" and your patch is fine.
Can this be applied ?
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2024-05-15 15:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240304161607.82759-1-marex@denx.de>
2024-03-05 8:55 ` [PATCH] mtd: spi-nor: Clear Winbond SR3 WPS bit on boot Michael Walle
2024-03-05 12:31 ` Marek Vasut
2024-03-05 12:50 ` Michael Walle
2024-03-05 15:37 ` Marek Vasut
2024-03-05 15:53 ` Michael Walle
2024-03-05 16:28 ` Marek Vasut
2024-03-05 16:55 ` Michael Walle
2024-03-05 18:54 ` Marek Vasut
2024-03-05 21:41 ` Michael Walle
2024-03-06 2:56 ` Marek Vasut
2024-03-06 12:55 ` Michael Walle
2024-05-15 14:55 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515848c8-65e3-41de-8a2c-af1c9e5351f1@denx.de \
--to=marex@denx.de \
--cc=Takahiro.Kuwano@infineon.com \
--cc=hai.pham.ud@renesas.com \
--cc=jagan@amarulasolutions.com \
--cc=jneuhauser@dh-electronics.com \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=venkatesh.abbarapu@amd.com \
--cc=vigneshr@ti.com \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).