Re: [PATCH] Skyhighmemory

From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Kyeongrho.Kim" <kr.kim@skyhighmemory.com>
Cc: "richard@nod.at" <richard@nod.at>,
	"vigneshr@ti.com" <vigneshr@ti.com>,
	"mmkurbanov@salutedevices.com" <mmkurbanov@salutedevices.com>,
	"ddrokosov@sberdevices.ru" <ddrokosov@sberdevices.ru>,
	"gch981213@gmail.com" <gch981213@gmail.com>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Mohamed Sardi <moh.sardi@skyhighmemory.com>,
	"Changsub.Shim" <changsub.shim@skyhighmemory.com>
Subject: Re: [PATCH] Skyhighmemory
Date: Tue, 5 Mar 2024 08:39:57 +0100	[thread overview]
Message-ID: <20240305083957.46e80312@xps-13> (raw)
In-Reply-To: <SE2P216MB2102DA0C880653E08D03747383222@SE2P216MB2102.KORP216.PROD.OUTLOOK.COM>

Hello,

kr.kim@skyhighmemory.com wrote on Tue, 5 Mar 2024 02:28:31 +0000:

> Hello Miquel,
> 
> Please find the reply in below.
> 
> I tried to send an email using 'git send-email', but '5.1.3 Invalid address' error is occurring, so I send it to Outlook first.

I'm sorry but I will now wait for your setup to be fixed.

> > spinand_device *spinand)  static int spinand_ecc_enable(struct spinand_device *spinand,  
> 
> >                       bool enable)  
> 
> >  {  
> 
> > +   /* SHM : always ECC enable */  
> 
> > +   if (spinand->flags & SPINAND_ON_DIE_ECC_MANDATORY)  
> 
> > +         return 0;  
> 
> > +  
> 
> 
> 
> Can you please move this logic to your vendor driver?
> 
> SHM's SPI Nand must have “ECC Always on” applied.

Why? Disabling the ECC is not possible? In this case extra care must be
taken in the driver.

> 
> However, I think there is no way to be moved to the vendor driver.
> 

...

> > +static int skyhigh_spinand_ooblayout_ecc(struct mtd_info *mtd, int section,  
> 
> > +                           struct mtd_oob_region *region)  
> 
> > +{  
> 
> > +   if (section)  
> 
> > +         return -ERANGE;  
> 
> > +  
> 
> > +   region->length = 0;  
> 
> > +   region->offset = mtd->oobsize;  
> 
> 
> 
> The ECC bytes are not stored anywhere?
> 
> There is no problem because skyhigh's ecc parity is stored in the internal hidden area and is not needed for them.

Please add a comment.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/