From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Baruch Siach <baruch@tkos.co.il>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: maps: physmap-core: fix flash size larger than 32-bit
Date: Mon, 26 Feb 2024 11:43:34 +0100 [thread overview]
Message-ID: <20240226104334.489164-1-miquel.raynal@bootlin.com> (raw)
In-Reply-To: <9fbf3664ce00f8b07867f1011834015f21d162a5.1707388458.git.baruch@tkos.co.il>
On Thu, 2024-02-08 at 10:34:18 UTC, Baruch Siach wrote:
> mtd-ram can potentially be larger than 4GB. get_bitmask_order() uses
> fls() that is not guaranteed to work with values larger than 32-bit.
> Specifically on aarch64 fls() returns 0 when all 32 LSB bits are clear.
> Use fls64() instead.
>
> Fixes: ba32ce95cbd987 ("mtd: maps: Merge gpio-addr-flash.c into physmap-core.c")
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.
Miquel
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2024-02-26 12:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 10:34 [PATCH] mtd: maps: physmap-core: fix flash size larger than 32-bit Baruch Siach
2024-02-26 10:43 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240226104334.489164-1-miquel.raynal@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=baruch@tkos.co.il \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).