From: Richard Weinberger <richard@nod.at>
To: Christian Heusel <christian@heusel.eu>
Cc: David Woodhouse <dwmw2@infradead.org>,
linux-mtd <linux-mtd@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
kernel-janitors <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] jffs2: print symbolic error name instead of error code
Date: Mon, 11 Mar 2024 13:56:27 +0100 (CET) [thread overview]
Message-ID: <1349276201.40757.1710161787719.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <b4oa6jak7f4hiaqcqpmasclaylqdhdzgne75a6nol6z33d4o7z@3soexkn4smz4>
----- Ursprüngliche Mail -----
> Von: "Christian Heusel" <christian@heusel.eu>
> An: "David Woodhouse" <dwmw2@infradead.org>, "richard" <richard@nod.at>, "linux-mtd" <linux-mtd@lists.infradead.org>,
> "linux-kernel" <linux-kernel@vger.kernel.org>
> CC: "kernel-janitors" <kernel-janitors@vger.kernel.org>
> Gesendet: Montag, 11. März 2024 13:47:40
> Betreff: Re: [PATCH] jffs2: print symbolic error name instead of error code
> On 24/02/11 01:39AM, Christian Heusel wrote:
>> Utilize the %pe print specifier to get the symbolic error name as a
>> string (i.e "-ENOMEM") in the log message instead of the error code to
>> increase its readablility.
>>
>> This change was suggested in
>> https://lore.kernel.org/all/92972476-0b1f-4d0a-9951-af3fc8bc6e65@suswa.mountain/
>>
>> Signed-off-by: Christian Heusel <christian@heusel.eu>
>> ---
>> fs/jffs2/background.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/jffs2/background.c b/fs/jffs2/background.c
>> index 6da92ecaf66d..bb0ee1a59e71 100644
>> --- a/fs/jffs2/background.c
>> +++ b/fs/jffs2/background.c
>> @@ -44,8 +44,8 @@ int jffs2_start_garbage_collect_thread(struct jffs2_sb_info
>> *c)
>>
>> tsk = kthread_run(jffs2_garbage_collect_thread, c, "jffs2_gcd_mtd%d",
>> c->mtd->index);
>> if (IS_ERR(tsk)) {
>> - pr_warn("fork failed for JFFS2 garbage collect thread: %ld\n",
>> - -PTR_ERR(tsk));
>> + pr_warn("fork failed for JFFS2 garbage collect thread: %pe\n",
>> + tsk);
>> complete(&c->gc_thread_exit);
>> ret = PTR_ERR(tsk);
>> } else {
>> --
>> 2.43.1
>
> Friendly ping on the above patch, since it's now a month after sending
> it :)
Thanks for the ping. Your patch looks good. I'll queue it.
Thanks,
//richard
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2024-03-11 12:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-11 0:39 [PATCH] jffs2: print symbolic error name instead of error code Christian Heusel
2024-02-18 1:13 ` Zhihao Cheng
2024-03-11 12:47 ` Christian Heusel
2024-03-11 12:56 ` Richard Weinberger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349276201.40757.1710161787719.JavaMail.zimbra@nod.at \
--to=richard@nod.at \
--cc=christian@heusel.eu \
--cc=dwmw2@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).