From: Lucas De Marchi <lucas.demarchi@intel.com>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: <linux-modules@vger.kernel.org>,
Emil Velikov <emil.velikov@collabora.com>
Subject: Re: Re: Re: Re: [PATCH 2/2] make: install/uninstall tools symlinks to kmod
Date: Tue, 20 Feb 2024 02:11:00 -0600 [thread overview]
Message-ID: <ed6fokoatmaussyvjzymgaymeaobieu22t4su4cb6cbni2cfh6@3luwbln63m6a> (raw)
In-Reply-To: <CACvgo53Y+JQA9A6VdwYyHiAvs8HPssotBbfmdPnPxG83Yq9Ztg@mail.gmail.com>
On Wed, Feb 14, 2024 at 04:22:44PM +0000, Emil Velikov wrote:
>On Tue, 6 Feb 2024 at 16:15, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
>>
>> On Mon, Feb 05, 2024 at 05:50:54PM +0000, Emil Velikov wrote:
>> >On Mon, 5 Feb 2024 at 14:30, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
>> >
>> >[snip]
>> >
>> >> >I'm not a huge fan of using relative symlinks, especially if the tool> >is run as root. In my experience that makes things harder to audit and
>> >> >prevent accidental breakages.
>> >>
>> >> I'm completely in the opposite camp. Relative symlinks actually make
>> >> sure the thing you are running is what you are expecting. Nothing should
>> >> really point outside of $prefix expecting that is mounted on /.
>> >>
>> >
>> >That is true and I fully agree. Yet the contents of DESTDIR are not
>> >meant to be run as-is - it's used for "staging" [1].
>> >
>> >[1] https://www.gnu.org/software/make/manual/html_node/DESTDIR.html
>> >
>> >> Several years back there was also the issue with packaging, which would
>> >> complain when symlinks pointed outside what was being packaged. It is
>> >> dangerous when using absolute symlinks because if the tool used to copy
>> >> follows the symlinks, it ends up with the wrong binary, copying the host
>> >> bin rather than what was just built.
>> >>
>> >
>> >That sounds like a horrible bug, which can easily break your system
>> >regardless of the project.
>> >
>> >Would you consider dropping the leading `./` aka can we use `$(LN_S)
>> >kmod $(DESTDIR)$(bindir)/$$tool;`?
>> >Seems to be prevailing on my system with over 90% instances.
>>
>> seems good to me. I will squash that and push.
sorry I went on vacations and didn't realize I hadn't pushed.
Now it's in and with the other patches fixing make distcheck
we are clear for a release. I will prep that this week.
thanks
Lucas De Marchi
>>
>
>Respectful poke?
>
>Thanks
>Emil
prev parent reply other threads:[~2024-02-20 8:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 14:43 [PATCH 0/2] Polish module_directory help string, install symlinks Emil Velikov via B4 Relay
2024-01-26 14:43 ` [PATCH 1/2] configure: tweak the module_directory help string Emil Velikov via B4 Relay
2024-01-26 14:43 ` [PATCH 2/2] make: install/uninstall tools symlinks to kmod Emil Velikov via B4 Relay
2024-01-29 16:40 ` Lucas De Marchi
2024-01-29 17:23 ` Emil Velikov
2024-01-29 22:09 ` Lucas De Marchi
2024-01-31 13:45 ` Emil Velikov
2024-01-31 13:52 ` Marco d'Itri
2024-02-02 18:53 ` Lucas De Marchi
2024-02-05 12:37 ` Emil Velikov
2024-02-05 14:30 ` Lucas De Marchi
2024-02-05 17:50 ` Emil Velikov
2024-02-06 16:15 ` Lucas De Marchi
2024-02-14 16:22 ` Emil Velikov
2024-02-20 8:11 ` Lucas De Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed6fokoatmaussyvjzymgaymeaobieu22t4su4cb6cbni2cfh6@3luwbln63m6a \
--to=lucas.demarchi@intel.com \
--cc=emil.l.velikov@gmail.com \
--cc=emil.velikov@collabora.com \
--cc=linux-modules@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).