From: Luis Chamberlain <mcgrof@kernel.org>
To: Yifan Hong <elsk@google.com>
Cc: "Masahiro Yamada" <masahiroy@kernel.org>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nicolas Schier" <nicolas@fjasle.eu>,
linux-modules@vger.kernel.org, linux-kbuild@vger.kernel.org,
"Matthias Männich" <maennich@google.com>,
"Ulises Mendez Martinez" <umendez@google.com>
Subject: Re: [PATCH v2] module: allow UNUSED_KSYMS_WHITELIST to be relative against objtree.
Date: Thu, 11 Apr 2024 09:29:30 -0700 [thread overview]
Message-ID: <ZhgP6nzoDAH6UqXB@bombadil.infradead.org> (raw)
In-Reply-To: <20240410194802.62036-1-elsk@google.com>
On Wed, Apr 10, 2024 at 07:48:02PM +0000, Yifan Hong wrote:
> If UNUSED_KSYMS_WHITELIST is a file generated
> before Kbuild runs, and the source tree is in
> a read-only filesystem, the developer must put
> the file somewhere and specify an absolute
> path to UNUSED_KSYMS_WHITELIST. This worked,
> but if IKCONFIG=y, an absolute path is embedded
> into .config and eventually into vmlinux, causing
> the build to be less reproducible when building
> on a different machine.
>
> This patch makes the handling of
> UNUSED_KSYMS_WHITELIST to be similar to
> MODULE_SIG_KEY.
>
> First, check if UNUSED_KSYMS_WHITELIST is an
> absolute path, just as before this patch. If so,
> use the path as is.
>
> If it is a relative path, use wildcard to check
> the existence of the file below objtree first.
> If it does not exist, fall back to the original
> behavior of adding $(srctree)/ before the value.
>
> After this patch, the developer can put the generated
> file in objtree, then use a relative path against
> objtree in .config, eradicating any absolute paths
> that may be evaluated differently on different machines.
>
> Signed-off-by: Yifan Hong <elsk@google.com>
Applied and pushed, thanks.
Luis
prev parent reply other threads:[~2024-04-11 16:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 19:37 [PATCH] module: allow UNUSED_KSYMS_WHITELIST to be relative against objtree Yifan Hong
2024-04-10 19:48 ` [PATCH v2] " Yifan Hong
2024-04-10 20:27 ` Elliot Berman
2024-04-10 20:41 ` Yifan Hong
2024-04-11 16:29 ` Luis Chamberlain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZhgP6nzoDAH6UqXB@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=elsk@google.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=maennich@google.com \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=nicolas@fjasle.eu \
--cc=umendez@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).