From: Michal Hocko <mhocko@suse.com>
To: Jean Delvare <jdelvare@suse.de>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] module: print module name on refcount error
Date: Thu, 14 Sep 2023 21:39:58 +0200 [thread overview]
Message-ID: <ZQNhjhhpG2aN8Xi6@dhcp22.suse.cz> (raw)
In-Reply-To: <20230828141830.02de4d90@endymion.delvare>
On Mon 28-08-23 14:18:30, Jean Delvare wrote:
[...]
> > > It would likely be better to use refcount_t instead of atomic_t.
> >
> > Patches welcomed.
>
> Michal, do I understand correctly that this would prevent the case our
> customer had (too many gets), but won't make a difference for actual
> too-many-puts situations?
yes, refcount_t cannot protect from too-many-puts because there is not
real way to protect from those AFAICS. At a certain moment you just drop
to 0 and lose your object and all following that is a UAF. But I do not
think this is actually the interesting case at all.
--
Michal Hocko
SUSE Labs
prev parent reply other threads:[~2023-09-14 19:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-26 10:32 [PATCH] module: print module name on refcount error Jean Delvare
2023-06-28 10:30 ` Michal Hocko
2023-07-04 12:43 ` Jean Delvare
2023-07-04 13:05 ` Michal Hocko
2023-07-04 14:35 ` Jean Delvare
2023-06-30 23:05 ` Luis Chamberlain
2023-07-01 15:57 ` Jean Delvare
2023-07-03 10:45 ` Jean Delvare
2023-07-03 13:47 ` Michal Hocko
2023-07-07 18:56 ` Luis Chamberlain
2023-07-10 5:43 ` Michal Hocko
2023-07-26 20:59 ` Luis Chamberlain
2023-08-28 12:18 ` Jean Delvare
2023-09-14 19:39 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQNhjhhpG2aN8Xi6@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=jdelvare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).