From: "Kuan-Ying Lee (李冠穎)" <Kuan-Ying.Lee@mediatek.com>
To: "matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"p.raghav@samsung.com" <p.raghav@samsung.com>,
"kbingham@kernel.org" <kbingham@kernel.org>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>,
"jan.kiszka@siemens.com" <jan.kiszka@siemens.com>,
"mcgrof@kernel.org" <mcgrof@kernel.org>
Cc: "Andrew Yang (楊智強)" <Andrew.Yang@mediatek.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"Qun-wei Lin (林群崴)" <Qun-wei.Lin@mediatek.com>,
"linux-modules@vger.kernel.org" <linux-modules@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"Chinwen Chang (張錦文)" <chinwen.chang@mediatek.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] scripts/gdb: fix 'lx-lsmod' show the wrong size
Date: Fri, 30 Jun 2023 01:01:35 +0000 [thread overview]
Message-ID: <956205d17a304364d1026db694d544cecfe28d50.camel@mediatek.com> (raw)
In-Reply-To: <20230620094834.14688-1-Kuan-Ying.Lee@mediatek.com>
Kindly ping, any comment?
Cc linux-modules.
Thanks,
Kuan-Ying Lee
On Tue, 2023-06-20 at 17:48 +0800, Kuan-Ying Lee wrote:
> 'lsmod' shows total core layout size, so we need to
> sum up all the sections in core layout in gdb scripts.
>
> / # lsmod
> kasan_test 200704 0 - Live 0xffff80007f640000
>
> Before patch:
> (gdb) lx-lsmod
> Address Module Size Used by
> 0xffff80007f640000 kasan_test 36864 0
>
> After patch:
> (gdb) lx-lsmod
> Address Module Size Used by
> 0xffff80007f640000 kasan_test 200704 0
>
> Fixes: b4aff7513df3 ("scripts/gdb: use mem instead of core_layout to
> get the module address")
> Signed-off-by: Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com>
> ---
> scripts/gdb/linux/constants.py.in | 3 +++
> scripts/gdb/linux/modules.py | 12 +++++++++---
> 2 files changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/gdb/linux/constants.py.in
> b/scripts/gdb/linux/constants.py.in
> index 50a92c4e9984..fab74ca9df6f 100644
> --- a/scripts/gdb/linux/constants.py.in
> +++ b/scripts/gdb/linux/constants.py.in
> @@ -64,6 +64,9 @@ LX_GDBPARSED(IRQ_HIDDEN)
>
> /* linux/module.h */
> LX_GDBPARSED(MOD_TEXT)
> +LX_GDBPARSED(MOD_DATA)
> +LX_GDBPARSED(MOD_RODATA)
> +LX_GDBPARSED(MOD_RO_AFTER_INIT)
>
> /* linux/mount.h */
> LX_VALUE(MNT_NOSUID)
> diff --git a/scripts/gdb/linux/modules.py
> b/scripts/gdb/linux/modules.py
> index 261f28640f4c..84933c4c1083 100644
> --- a/scripts/gdb/linux/modules.py
> +++ b/scripts/gdb/linux/modules.py
> @@ -73,11 +73,17 @@ class LxLsmod(gdb.Command):
> " " if utils.get_long_type().sizeof == 8 else
> ""))
>
> for module in module_list():
> - layout = module['mem'][constants.LX_MOD_TEXT]
> + total_size = 0
> + for i in range(constants.LX_MOD_TEXT,
> constants.LX_MOD_RO_AFTER_INIT + 1):
> + layout = module['mem'][i]
> + if i == constants.LX_MOD_TEXT:
> + text_addr = str(layout['base']).split()[0]
> + total_size += layout['size']
> +
> gdb.write("{address} {name:<19}
> {size:>8} {ref}".format(
> - address=str(layout['base']).split()[0],
> + address=text_addr,
> name=module['name'].string(),
> - size=str(layout['size']),
> + size=str(total_size),
> ref=str(module['refcnt']['counter'] - 1)))
>
> t = self._module_use_type.get_type().pointer()
> --
> 2.18.0
>
parent reply other threads:[~2023-06-30 1:02 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20230620094834.14688-1-Kuan-Ying.Lee@mediatek.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=956205d17a304364d1026db694d544cecfe28d50.camel@mediatek.com \
--to=kuan-ying.lee@mediatek.com \
--cc=Andrew.Yang@mediatek.com \
--cc=Qun-wei.Lin@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chinwen.chang@mediatek.com \
--cc=jan.kiszka@siemens.com \
--cc=kbingham@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=linux-modules@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=mcgrof@kernel.org \
--cc=p.raghav@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).