From: Shuah Khan <skhan@linuxfoundation.org>
To: Luis Chamberlain <mcgrof@kernel.org>,
Muhammad Usama Anjum <usama.anjum@collabora.com>,
Shuah Khan <shuah@kernel.org>
Cc: linux-kselftest@vger.kernel.org, gregkh@linuxfoundation.org,
tiwai@suse.de, tianfei.zhang@intel.com,
russell.h.weight@intel.com, keescook@chromium.org,
tweek@google.com, a.manzanares@samsung.com, dave@stgolabs.net,
vincenzopalazzodev@gmail.com, linux-modules@vger.kernel.org,
linux-kernel@vger.kernel.org,
Lucas De Marchi <lucas.de.marchi@gmail.com>,
"Darrick J. Wong" <djwong@kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests: allow runners to override the timeout
Date: Mon, 5 Jun 2023 13:01:52 -0600 [thread overview]
Message-ID: <3a9c8407-7ffd-e6c0-74d2-574c99fd739a@linuxfoundation.org> (raw)
In-Reply-To: <ZG6WlUZZN4etzM2k@bombadil.infradead.org>
On 5/24/23 16:58, Luis Chamberlain wrote:
> On Thu, May 11, 2023 at 08:26:42AM -0700, Luis Chamberlain wrote:
>> On Fri, Apr 28, 2023 at 1:34 AM Muhammad Usama Anjum
>> <usama.anjum@collabora.com> wrote:
>>>
>>> On 4/15/23 12:38 AM, Luis Chamberlain wrote:
>>>> The default timeout for selftests tests is 45 seconds. Although
>>>> we already have 13 settings for tests of about 96 sefltests which
>>>> use a timeout greater than this, we want to try to avoid encouraging
>>>> more tests to forcing a higher test timeout as selftests strives to
>>>> run all tests quickly. Selftests also uses the timeout as a non-fatal
>>>> error. Only tests runners which have control over a system would know
>>>> if to treat a timeout as fatal or not.
>>>>
>>>> To help with all this:
>>>>
>>>> o Enhance documentation to avoid future increases of insane timeouts
>>>> o Add the option to allow overriding the default timeout with test
>>>> runners with a command line option
>>>>
>>>> Suggested-by: Shuah Khan <skhan@linuxfoundation.org>
>>>> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
>>> Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
>>> Tested-by:Muhammad Usama Anjum <usama.anjum@collabora.com>
>>
>> Shuah, just a friendly poke! This is needed to allow me to enable full
>> automation for kdevops for selftests.
>
> Shuah, friendly re-poke.
>
> Luis
Thanks. I will apply this for next.
thanks,
-- Shuah
prev parent reply other threads:[~2023-06-05 19:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 19:38 [PATCH] selftests: allow runners to override the timeout Luis Chamberlain
2023-04-28 8:33 ` Muhammad Usama Anjum
2023-05-11 15:26 ` Luis Chamberlain
2023-05-24 22:58 ` Luis Chamberlain
2023-06-05 19:01 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a9c8407-7ffd-e6c0-74d2-574c99fd739a@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=a.manzanares@samsung.com \
--cc=dave@stgolabs.net \
--cc=djwong@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=lucas.de.marchi@gmail.com \
--cc=mcgrof@kernel.org \
--cc=russell.h.weight@intel.com \
--cc=shuah@kernel.org \
--cc=tianfei.zhang@intel.com \
--cc=tiwai@suse.de \
--cc=tweek@google.com \
--cc=usama.anjum@collabora.com \
--cc=vincenzopalazzodev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).