From: Mauro Carvalho Chehab <mchehab@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
linux-kernel@vger.kernel.org, stable <stable@kernel.org>,
Stefan Lippers-Hollmann <s.l-h@gmx.de>,
Christoph Hellwig <hch@lst.de>,
linux-media@vger.kernel.org, linux-modules@vger.kernel.org
Subject: Re: [PATCH] media: dvb: symbol fixup for dvb_attach()
Date: Sat, 9 Sep 2023 12:19:41 +0200 [thread overview]
Message-ID: <20230909121941.30a1b1f0@sal.lan> (raw)
In-Reply-To: <2023090852-stoppable-jackpot-549f@gregkh>
Em Fri, 8 Sep 2023 17:35:07 +0100
Greg Kroah-Hartman <gregkh@linuxfoundation.org> escreveu:
> On Fri, Sep 08, 2023 at 09:21:29AM -0700, Luis Chamberlain wrote:
> > On Fri, Sep 08, 2023 at 10:20:36AM +0100, Greg Kroah-Hartman wrote:
> > > In commit 9011e49d54dc ("modules: only allow symbol_get of
> > > EXPORT_SYMBOL_GPL modules") the use of symbol_get is properly restricted
> > > to GPL-only marked symbols. This interacts oddly with the DVB logic
> > > which only uses dvb_attach() to load the dvb driver which then uses
> > > symbol_get().
> > >
> > > Fix this up by properly marking all of the dvb_attach attach symbols as
> > > EXPORT_SYMBOL_GPL().
> > >
> > > Fixes: 9011e49d54dc ("modules: only allow symbol_get of EXPORT_SYMBOL_GPL modules")
> > > Cc: stable <stable@kernel.org>
> > > Reported-by: Stefan Lippers-Hollmann <s.l-h@gmx.de>
> > > Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> > > Cc: Luis Chamberlain <mcgrof@kernel.org>
> > > Cc: Christoph Hellwig <hch@lst.de>
> > > Cc: linux-media@vger.kernel.org
> > > Cc: linux-modules@vger.kernel.org
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > ---
> > > Luis, do you want to take this through your tree? Or Mauro's? Or I can
> > > take it through mine, it should get to Linus soon as this is causing
> > > regressions in his tree.
> >
> > You've done the work so it is up to you, whatever helps you expedite it
> > as it already hit stable. Feel free to take it through your tree.
>
> If you ack it, I can take it now through my tree and send it to Linus
> tomorrow.
You can send it via your trees. So:
Acked-by: Mauro Carvalho Chehab <mchehab@kernel.org>
>
> thanks,
>
> greg k-h
prev parent reply other threads:[~2023-09-09 10:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-08 9:20 [PATCH] media: dvb: symbol fixup for dvb_attach() Greg Kroah-Hartman
2023-09-08 9:49 ` Hans Verkuil
2023-09-08 16:21 ` Luis Chamberlain
2023-09-08 16:35 ` Greg Kroah-Hartman
2023-09-08 23:09 ` Luis Chamberlain
2023-09-09 10:19 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230909121941.30a1b1f0@sal.lan \
--to=mchehab@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=s.l-h@gmx.de \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).