From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Steve French <smfrench@gmail.com>, CIFS <linux-cifs@vger.kernel.org>
Cc: Winston Wen <wentao@uniontech.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Luis Chamberlain <mcgrof@kernel.org>,
linux-modules@vger.kernel.org
Subject: linux-next: build failure after merge of the cifs tree
Date: Thu, 20 Jul 2023 10:35:40 +1000 [thread overview]
Message-ID: <20230720103540.0436273d@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 1215 bytes --]
Hi all,
After merging the cifs tree, today's linux-next build (x86_64
allmodconfig) failed like this:
fs/smb/client/connect.c: In function 'cifs_get_smb_ses':
fs/smb/client/connect.c:2293:49: error: passing argument 1 of 'load_nls' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
2293 | ses->local_nls = load_nls(ctx->local_nls->charset);
| ~~~~~~~~~~~~~~^~~~~~~~~
In file included from fs/smb/client/cifsproto.h:10,
from fs/smb/client/connect.c:37:
include/linux/nls.h:50:35: note: expected 'char *' but argument is of type 'const char *'
50 | extern struct nls_table *load_nls(char *);
| ^~~~~~
Caused by commit
46055407cd4a ("cifs: fix charset issue in reconnection")
I have used the cifs tree from next-20230719 for today.
It looks as though the parameter to load_nls could be made const safely
as it is just passed to try_then_request_module() passes it to
__request_module() which just passes it to vsnprintf() to construct the
module name. There does not appear to be any maintainer for fs/nls ...
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2023-07-20 0:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 0:35 Stephen Rothwell [this message]
2023-07-20 0:47 ` linux-next: build failure after merge of the cifs tree Steve French
2023-07-20 1:00 ` Stephen Rothwell
2023-07-20 1:33 ` Winston Wen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230720103540.0436273d@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=smfrench@gmail.com \
--cc=wentao@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).