From: Hans de Goede <hdegoede@redhat.com>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: linux-mmc@vger.kernel.org,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Andy Shevchenko <andy@kernel.org>
Subject: Re: [PATCH v2 4/6] mmc: sdhci-acpi: Disable UHS/1.8V modes on Lenovo Yoga Tablet 2 series sdcard slot
Date: Wed, 10 Apr 2024 19:11:14 +0200 [thread overview]
Message-ID: <f1389cde-4273-4e4b-a24e-c61c45a82399@redhat.com> (raw)
In-Reply-To: <199bb4aa-c6b5-453e-be37-58bbf468800c@intel.com>
Hi Adrian,
On 4/9/24 12:37 PM, Adrian Hunter wrote:
> On 8/04/24 22:52, Hans de Goede wrote:
>> Unlike all other Bay Trail devices I have (quite a few) the BIOS on
>> the Lenovo Yoga Tablet 2 830 / 1050 and Lenovo Yoga Tablet 2 Pro 1380 (8",
>> 10" and 13") models sets the SDHCI_SUPPORT_DDR50 bit in the sdcard slots'
>> SDHCI controller's Caps_1 register which causes Linux to try and use
>> UHS SDR12 / SDR25 and DDR50 modes on UHS cards.
>>
>> These tablets do have 1.8V signalling implemented in the hw level through
>> the Bay Trail SoC's SD3_1P8EN pin. But trying to use UHS modes leads to
>> lots of errors like these:
>>
>> [ 225.272001] mmc2: Unexpected interrupt 0x04000000.
>> [ 225.272024] mmc2: sdhci: ============ SDHCI REGISTER DUMP ===========
>> [ 225.272034] mmc2: sdhci: Sys addr: 0x0712c400 | Version: 0x0000b502
>> [ 225.272044] mmc2: sdhci: Blk size: 0x00007200 | Blk cnt: 0x00000007
>> [ 225.272054] mmc2: sdhci: Argument: 0x00000000 | Trn mode: 0x00000023
>> [ 225.272064] mmc2: sdhci: Present: 0x01e20002 | Host ctl: 0x00000016
>> [ 225.272073] mmc2: sdhci: Power: 0x0000000f | Blk gap: 0x00000000
>> [ 225.272082] mmc2: sdhci: Wake-up: 0x00000000 | Clock: 0x00000107
>> [ 225.272092] mmc2: sdhci: Timeout: 0x0000000e | Int stat: 0x00000001
>> [ 225.272101] mmc2: sdhci: Int enab: 0x03ff000b | Sig enab: 0x03ff000b
>> [ 225.272110] mmc2: sdhci: ACmd stat: 0x00000000 | Slot int: 0x00000001
>> [ 225.272119] mmc2: sdhci: Caps: 0x076864b2 | Caps_1: 0x00000004
>> [ 225.272129] mmc2: sdhci: Cmd: 0x00000c1b | Max curr: 0x00000000
>> [ 225.272138] mmc2: sdhci: Resp[0]: 0x00000c00 | Resp[1]: 0x00000000
>> [ 225.272147] mmc2: sdhci: Resp[2]: 0x00000000 | Resp[3]: 0x00000900
>> [ 225.272155] mmc2: sdhci: Host ctl2: 0x0000000c
>> [ 225.272164] mmc2: sdhci: ADMA Err: 0x00000003 | ADMA Ptr: 0x0712c200
>> [ 225.272172] mmc2: sdhci: ============================================
>>
>
> 0x04000000 is so-called "Tuning Error" which oddly the SDHCI driver
> does not support / enable.
>
> Could try making the IRQ handler process it and see if that helps:
Good news I have applied this diff and with that everything seems
to just work. No need to add the SDHCI_QUIRK2_PRESET_VALUE_BROKEN, just
this patch from you and then things work.
I'll prepare a v3 patch-set replacing this patch with your "Tuning Error"
handling patch with you as the author.
Regards,
Hans
>
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index c79f73459915..746f4cf7ab03 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -3439,12 +3439,18 @@ static void sdhci_data_irq(struct sdhci_host *host, u32 intmask)
> host->data->error = -EILSEQ;
> if (!mmc_op_tuning(SDHCI_GET_CMD(sdhci_readw(host, SDHCI_COMMAND))))
> sdhci_err_stats_inc(host, DAT_CRC);
> - } else if ((intmask & SDHCI_INT_DATA_CRC) &&
> + } else if ((intmask & (SDHCI_INT_DATA_CRC | SDHCI_INT_TUNING_ERROR)) &&
> SDHCI_GET_CMD(sdhci_readw(host, SDHCI_COMMAND))
> != MMC_BUS_TEST_R) {
> host->data->error = -EILSEQ;
> if (!mmc_op_tuning(SDHCI_GET_CMD(sdhci_readw(host, SDHCI_COMMAND))))
> sdhci_err_stats_inc(host, DAT_CRC);
> + if (intmask & SDHCI_INT_TUNING_ERROR) {
> + u16 ctrl2 = sdhci_readw(host, SDHCI_HOST_CONTROL2);
> +
> + ctrl2 &= ~SDHCI_CTRL_TUNED_CLK;
> + sdhci_writew(host, ctrl2, SDHCI_HOST_CONTROL2);
> + }
> } else if (intmask & SDHCI_INT_ADMA_ERROR) {
> pr_err("%s: ADMA error: 0x%08x\n", mmc_hostname(host->mmc),
> intmask);
> @@ -3979,7 +3985,7 @@ bool sdhci_cqe_irq(struct sdhci_host *host, u32 intmask, int *cmd_error,
> } else
> *cmd_error = 0;
>
> - if (intmask & (SDHCI_INT_DATA_END_BIT | SDHCI_INT_DATA_CRC)) {
> + if (intmask & (SDHCI_INT_DATA_END_BIT | SDHCI_INT_DATA_CRC | SDHCI_INT_TUNING_ERROR)) {
> *data_error = -EILSEQ;
> if (!mmc_op_tuning(SDHCI_GET_CMD(sdhci_readw(host, SDHCI_COMMAND))))
> sdhci_err_stats_inc(host, DAT_CRC);
> diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
> index a20864fc0641..957c7a917ffb 100644
> --- a/drivers/mmc/host/sdhci.h
> +++ b/drivers/mmc/host/sdhci.h
> @@ -158,6 +158,7 @@
> #define SDHCI_INT_BUS_POWER 0x00800000
> #define SDHCI_INT_AUTO_CMD_ERR 0x01000000
> #define SDHCI_INT_ADMA_ERROR 0x02000000
> +#define SDHCI_INT_TUNING_ERROR 0x04000000
>
> #define SDHCI_INT_NORMAL_MASK 0x00007FFF
> #define SDHCI_INT_ERROR_MASK 0xFFFF8000
> @@ -169,7 +170,7 @@
> SDHCI_INT_DATA_AVAIL | SDHCI_INT_SPACE_AVAIL | \
> SDHCI_INT_DATA_TIMEOUT | SDHCI_INT_DATA_CRC | \
> SDHCI_INT_DATA_END_BIT | SDHCI_INT_ADMA_ERROR | \
> - SDHCI_INT_BLK_GAP)
> + SDHCI_INT_BLK_GAP | SDHCI_INT_TUNING_ERROR)
> #define SDHCI_INT_ALL_MASK ((unsigned int)-1)
>
> #define SDHCI_CQE_INT_ERR_MASK ( \
>
>
next prev parent reply other threads:[~2024-04-10 17:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 19:52 [PATCH v2 0/6] mmc: sdhci-acpi: Add some DMI quirks to fix various issues on Bay Trail devices Hans de Goede
2024-04-08 19:52 ` [PATCH v2 1/6] mmc: core: Add mmc_gpiod_set_cd_config() function Hans de Goede
2024-04-08 19:52 ` [PATCH v2 2/6] mmc: sdhci-acpi: Sort DMI quirks alphabetically Hans de Goede
2024-04-08 19:52 ` [PATCH v2 3/6] mmc: sdhci-acpi: Fix Lenovo Yoga Tablet 2 Pro 1380 sdcard slot not working Hans de Goede
2024-04-08 19:52 ` [PATCH v2 4/6] mmc: sdhci-acpi: Disable UHS/1.8V modes on Lenovo Yoga Tablet 2 series sdcard slot Hans de Goede
2024-04-09 10:37 ` Adrian Hunter
2024-04-09 11:39 ` Hans de Goede
2024-04-10 17:11 ` Hans de Goede [this message]
2024-04-08 19:52 ` [PATCH v2 5/6] mmc: sdhci-acpi: Disable write protect detection on Toshiba WT10-A Hans de Goede
2024-04-08 19:52 ` [PATCH v2 6/6] mmc: sdhci-acpi: Add quirk to enable pull-up on the card-detect GPIO on Asus T100TA Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1389cde-4273-4e4b-a24e-c61c45a82399@redhat.com \
--to=hdegoede@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=andy@kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).