From: Krzysztof Kozlowski <krzk@kernel.org>
To: Adrian Hunter <adrian.hunter@intel.com>,
Angelo Dureghello <adureghello@baylibre.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Vignesh Raghavendra <vigneshr@ti.com>,
Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
Ben Dooks <ben-linux@fluff.org>,
Jaehoon Chung <jh80.chung@samsung.com>
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] mmc: sdhci-s3c: Choose sdhci_ops based on variant
Date: Sun, 14 Apr 2024 16:05:35 +0200 [thread overview]
Message-ID: <be704175-60c5-415f-93d2-c6aaa2214b40@kernel.org> (raw)
In-Reply-To: <20240414-mmc-const-sdhci-ops-v1-5-178539d68093@kernel.org>
On 14/04/2024 09:15, Krzysztof Kozlowski wrote:
>
> -static struct sdhci_ops sdhci_s3c_ops = {
> +static const struct sdhci_ops sdhci_s3c_ops_s3c6410 = {
> .get_max_clock = sdhci_s3c_get_max_clk,
> .set_clock = sdhci_s3c_set_clock,
> .get_min_clock = sdhci_s3c_get_min_clock,
> @@ -421,6 +423,15 @@ static struct sdhci_ops sdhci_s3c_ops = {
> .set_uhs_signaling = sdhci_set_uhs_signaling,
> };
>
> +static const struct sdhci_ops sdhci_s3c_ops_exynos4 = {
> + .get_max_clock = sdhci_cmu_get_max_clock,
> + .set_clock = sdhci_cmu_set_clock,
> + .get_min_clock = sdhci_cmu_get_min_clock,
> + .set_bus_width = sdhci_set_bus_width,
> + .reset = sdhci_reset,
> + .set_uhs_signaling = sdhci_set_uhs_signaling,
> +};
> +
> #ifdef CONFIG_OF
LKP reported now unused sdhci_s3c_ops_exynos4 for !CONFIG_OF. I will
send v2 (today, due to travel)
Best regards,
Krzysztof
prev parent reply other threads:[~2024-04-14 14:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-14 7:15 [PATCH 0/5] mmc: Constify struct sdhci_ops Krzysztof Kozlowski
2024-04-14 7:15 ` [PATCH 1/5] mmc: sdhci-esdhc-mcf: " Krzysztof Kozlowski
2024-04-14 7:15 ` [PATCH 2/5] mmc: sdhci-omap: " Krzysztof Kozlowski
2024-04-14 7:15 ` [PATCH 3/5] mmc: sdhci-sprd: " Krzysztof Kozlowski
2024-04-14 7:15 ` [PATCH 4/5] mmc: sdhci_am654: " Krzysztof Kozlowski
2024-04-14 7:15 ` [PATCH 5/5] mmc: sdhci-s3c: Choose sdhci_ops based on variant Krzysztof Kozlowski
2024-04-14 14:05 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be704175-60c5-415f-93d2-c6aaa2214b40@kernel.org \
--to=krzk@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=adureghello@baylibre.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=ben-linux@fluff.org \
--cc=jh80.chung@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=vigneshr@ti.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).