From: Ulf Hansson <ulf.hansson@linaro.org>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc: Jaehoon Chung <jh80.chung@samsung.com>,
Yang Xiwen <forbidden405@outlook.com>,
kernel@collabora.com, kernel-janitors@vger.kernel.org,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: dw_mmc: remove unneeded assignment
Date: Mon, 25 Mar 2024 14:18:40 +0100 [thread overview]
Message-ID: <CAPDyKFrmJjv1WEc2yZFXKHxtN-vbS1k3VMeRyKdFiJkc5Uoimw@mail.gmail.com> (raw)
In-Reply-To: <20240307122129.2359553-1-usama.anjum@collabora.com>
On Thu, 7 Mar 2024 at 13:21, Muhammad Usama Anjum
<usama.anjum@collabora.com> wrote:
>
> The err is being set to 0 and replaced every time after this
> assignment. Remove this assignment as it is extraneous.
>
> Fixes: 25d043841db1 ("mmc: dw_mmc: add support for hi3798mv200")
Again, this isn't needed I think, so I have dropped it.
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Applied for next and by amending the commit message prefix to "mmc:
dw_mmc-hi3798mv200", thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/dw_mmc-hi3798mv200.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-hi3798mv200.c b/drivers/mmc/host/dw_mmc-hi3798mv200.c
> index 989ae8dda7228..96af693e3e37c 100644
> --- a/drivers/mmc/host/dw_mmc-hi3798mv200.c
> +++ b/drivers/mmc/host/dw_mmc-hi3798mv200.c
> @@ -133,7 +133,6 @@ static int dw_mci_hi3798mv200_execute_tuning_mix_mode(struct dw_mci_slot *slot,
> goto tuning_out;
>
> prev_err = err;
> - err = 0;
> }
>
> tuning_out:
> --
> 2.39.2
>
next prev parent reply other threads:[~2024-03-25 13:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 12:21 [PATCH] mmc: dw_mmc: remove unneeded assignment Muhammad Usama Anjum
2024-03-07 12:22 ` Yang Xiwen
2024-03-07 14:51 ` Muhammad Usama Anjum
2024-03-07 15:01 ` Dan Carpenter
2024-03-07 12:24 ` AngeloGioacchino Del Regno
2024-03-25 7:06 ` Muhammad Usama Anjum
2024-03-25 13:18 ` Ulf Hansson [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-03-07 14:50 Muhammad Usama Anjum
2024-03-25 7:06 ` Muhammad Usama Anjum
2024-03-25 13:18 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFrmJjv1WEc2yZFXKHxtN-vbS1k3VMeRyKdFiJkc5Uoimw@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=forbidden405@outlook.com \
--cc=jh80.chung@samsung.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).