From: Ulf Hansson <ulf.hansson@linaro.org>
To: Maksim Kiselev <bigunclemax@gmail.com>
Cc: Drew Fustini <drew@pdp7.com>, Xi Ruoyao <xry111@xry111.site>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] mmc: sdhci-of-dwcmshc: th1520: Increase tuning loop count to 128
Date: Thu, 4 Apr 2024 11:31:01 +0200 [thread overview]
Message-ID: <CAPDyKFqat_wAa1zCH+VAebs4R3LodvDJ13Af5CU9xvzX6rzKTw@mail.gmail.com> (raw)
In-Reply-To: <20240402093539.184287-1-bigunclemax@gmail.com>
On Tue, 2 Apr 2024 at 11:36, Maksim Kiselev <bigunclemax@gmail.com> wrote:
>
> Fix SD card tuning error by increasing tuning loop count
> from 40(MAX_TUNING_LOOP) to 128.
>
> For some reason the tuning algorithm requires to move through all the taps
> of delay line even if the THRESHOLD_MODE (bit 2 in AT_CTRL_R) is used
> instead of the LARGEST_WIN_MODE.
>
> Tested-by: Drew Fustini <drew@pdp7.com>
> Tested-by: Xi Ruoyao <xry111@xry111.site>
> Signed-off-by: Maksim Kiselev <bigunclemax@gmail.com>
Applied for fixes and by adding a fixes+stable tag, thanks!
Kind regards
Uffe
> ---
> Previous discussion was here:
> https://lore.kernel.org/lkml/CALHCpMhc1F5Ue7U_gsDXREHUZRVQJNYRCJxYxoNqbN=-39jf7A@mail.gmail.com/
>
> drivers/mmc/host/sdhci-of-dwcmshc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/sdhci-of-dwcmshc.c b/drivers/mmc/host/sdhci-of-dwcmshc.c
> index 8d6cfb648096..1001b6ea1a89 100644
> --- a/drivers/mmc/host/sdhci-of-dwcmshc.c
> +++ b/drivers/mmc/host/sdhci-of-dwcmshc.c
> @@ -706,6 +706,7 @@ static int th1520_execute_tuning(struct sdhci_host *host, u32 opcode)
>
> /* perform tuning */
> sdhci_start_tuning(host);
> + host->tuning_loop_count = 128;
> host->tuning_err = __sdhci_execute_tuning(host, opcode);
> if (host->tuning_err) {
> /* disable auto-tuning upon tuning error */
> --
> 2.40.1
>
prev parent reply other threads:[~2024-04-04 9:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 9:35 [PATCH v1] mmc: sdhci-of-dwcmshc: th1520: Increase tuning loop count to 128 Maksim Kiselev
2024-04-04 8:28 ` Adrian Hunter
2024-04-04 9:31 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFqat_wAa1zCH+VAebs4R3LodvDJ13Af5CU9xvzX6rzKTw@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=bigunclemax@gmail.com \
--cc=drew@pdp7.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).