From: Ulf Hansson <ulf.hansson@linaro.org>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: linux-amlogic@lists.infradead.org, linux-mmc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 0/2] mmc: meson-mx-sdhc: two small cleanups
Date: Wed, 28 Feb 2024 14:03:20 +0100 [thread overview]
Message-ID: <CAPDyKFqGWm3pFr5KOEc6c_n+b+NJe9PV_T65bU5udRQPZX72QA@mail.gmail.com> (raw)
In-Reply-To: <20240217100200.1494980-1-martin.blumenstingl@googlemail.com>
On Sat, 17 Feb 2024 at 11:02, Martin Blumenstingl
<martin.blumenstingl@googlemail.com> wrote:
>
> Hello Ulf,
>
> here are two small cleanups for the meson-mx-sdhc driver.
>
> The first one is resolves a TODO comment from when the driver was
> originally introduced where devm_clk_hw_get_clk() was not available
> yet. Nowadays it is and we can and should use it.
>
> The second one removes an incorrect .card_hw_reset callback from the
> driver's mmc_host_ops. This part has never been correct as we're
> resetting the host controller, not the card. It didn't seem to cause
> any issues so far, which is why I don't think that it's -stable
> material.
>
>
>
> Martin Blumenstingl (2):
> mmc: meson-mx-sdhc: Use devm_clk_hw_get_clk() for clock retrieval
> mmc: meson-mx-sdhc: Remove .card_hw_reset callback
>
> drivers/mmc/host/meson-mx-sdhc-clkc.c | 43 ++++++++++++++-------------
> drivers/mmc/host/meson-mx-sdhc-mmc.c | 13 ++++----
> 2 files changed, 28 insertions(+), 28 deletions(-)
Applied for next, thanks!
Kind regards
Uffe
prev parent reply other threads:[~2024-02-28 13:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-17 10:01 [PATCH v1 0/2] mmc: meson-mx-sdhc: two small cleanups Martin Blumenstingl
2024-02-17 10:01 ` [PATCH v1 1/2] mmc: meson-mx-sdhc: Use devm_clk_hw_get_clk() for clock retrieval Martin Blumenstingl
2024-02-17 10:02 ` [PATCH v1 2/2] mmc: meson-mx-sdhc: Remove .card_hw_reset callback Martin Blumenstingl
2024-02-28 13:03 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFqGWm3pFr5KOEc6c_n+b+NJe9PV_T65bU5udRQPZX72QA@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).