From: Ulf Hansson <ulf.hansson@linaro.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: cjb@laptop.org, linux-arm-kernel@lists.infradead.org,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mmc: wmt-sdmmc: remove an incorrect release_mem_region() call in the .remove function
Date: Tue, 5 Mar 2024 13:14:34 +0100 [thread overview]
Message-ID: <CAPDyKFpp3ODa+7z-Nx+ZLc2fqe6-=4MRQsQbKNVWb99u5-WasA@mail.gmail.com> (raw)
In-Reply-To: <bb0bb1ed1e18de55e8c0547625bde271e64b8c31.1708983064.git.christophe.jaillet@wanadoo.fr>
On Mon, 26 Feb 2024 at 22:37, Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
>
> This looks strange to call release_mem_region() in a remove function
> without any request_mem_region() in the probe or "struct resource"
> somewhere.
>
> So remove the corresponding code.
>
> Fixes: 3a96dff0f828 ("mmc: SD/MMC Host Controller for Wondermedia WM8505/WM8650")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Applied for next, thanks!
> ---
> This patch is speculative. Review with care.
> Compile tested only.
It looks to me that $subject patch doesn't make things any worse.
Potentially we may want to call request|release_resource() (or
similar) during probe/remove, but as that isn't done during probe
today, I decided to pick this up as is.
Kind regards
Uffe
> ---
> drivers/mmc/host/wmt-sdmmc.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/mmc/host/wmt-sdmmc.c b/drivers/mmc/host/wmt-sdmmc.c
> index 77d5f1d24489..860380931b6c 100644
> --- a/drivers/mmc/host/wmt-sdmmc.c
> +++ b/drivers/mmc/host/wmt-sdmmc.c
> @@ -883,7 +883,6 @@ static void wmt_mci_remove(struct platform_device *pdev)
> {
> struct mmc_host *mmc;
> struct wmt_mci_priv *priv;
> - struct resource *res;
> u32 reg_tmp;
>
> mmc = platform_get_drvdata(pdev);
> @@ -911,9 +910,6 @@ static void wmt_mci_remove(struct platform_device *pdev)
> clk_disable_unprepare(priv->clk_sdmmc);
> clk_put(priv->clk_sdmmc);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - release_mem_region(res->start, resource_size(res));
> -
> mmc_free_host(mmc);
>
> dev_info(&pdev->dev, "WMT MCI device removed\n");
> --
> 2.43.2
>
prev parent reply other threads:[~2024-03-05 12:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 21:37 [PATCH] mmc: wmt-sdmmc: remove an incorrect release_mem_region() call in the .remove function Christophe JAILLET
2024-03-05 12:14 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFpp3ODa+7z-Nx+ZLc2fqe6-=4MRQsQbKNVWb99u5-WasA@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=cjb@laptop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).