From: Ping-Ke Shih <pkshih@realtek.com>
To: Ping-Ke Shih <pkshih@realtek.com>,
Fiona Klute <fiona.klute@gmx.de>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: "Kalle Valo" <kvalo@kernel.org>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"Pavel Machek" <pavel@ucw.cz>, "Ondřej Jirman" <megi@xff.cz>
Subject: RE: [PATCH 5/9] wifi: rtw88: Add rtw8703b.c
Date: Wed, 7 Feb 2024 05:58:06 +0000 [thread overview]
Message-ID: <96b723081b434800b91abaedf1df14a8@realtek.com> (raw)
In-Reply-To: <28c1571cc90b49ce928ddb929e2bc93f@realtek.com>
> -----Original Message-----
> From: Ping-Ke Shih <pkshih@realtek.com>
> Sent: Tuesday, February 6, 2024 9:38 AM
> To: Fiona Klute <fiona.klute@gmx.de>; linux-wireless@vger.kernel.org
> Cc: Kalle Valo <kvalo@kernel.org>; Ulf Hansson <ulf.hansson@linaro.org>; linux-mmc@vger.kernel.org; Pavel
> Machek <pavel@ucw.cz>; Ondřej Jirman <megi@xff.cz>
> Subject: RE: [PATCH 5/9] wifi: rtw88: Add rtw8703b.c
>
>
>
> > -----Original Message-----
> > From: Fiona Klute <fiona.klute@gmx.de>
> > Sent: Tuesday, February 6, 2024 3:06 AM
> > To: Ping-Ke Shih <pkshih@realtek.com>; linux-wireless@vger.kernel.org
> > Cc: Kalle Valo <kvalo@kernel.org>; Ulf Hansson <ulf.hansson@linaro.org>; linux-mmc@vger.kernel.org;
> Pavel
> > Machek <pavel@ucw.cz>; Ondřej Jirman <megi@xff.cz>
> > Subject: Re: [PATCH 5/9] wifi: rtw88: Add rtw8703b.c
> >
> > >> +
> > >> + if (ret != 0)
> > >> + return ret;
> > >> +
> > >> +#ifdef CONFIG_OF
> > >> + /* Prefer MAC from DT, if available. On some devices like the
> > >> + * Pinephone that might be the only way to get a valid MAC.
> > >> + */
> > >> + struct device_node *node = rtwdev->dev->of_node;
> > >
> > > Should move this statement to topmost of this function? no compiler warning?
> > >
> > > Or, make an individual function to read mac addr from DT?
> >
> > I can move that to a separate function if you prefer, see below for the
> > compiler warning.
>
> Because this is CONFIG_OF chunk, it will look like below if you move declaration upward:
>
> #ifdef CONFIG_OF
> struct device_node *node = rtwdev->dev->of_node;
> #endif
> // other declaration ...
>
> // other code
> #ifdef CONFIG_OF
> if (node) {
> ...
> }
> #endif
>
> It seems like too much #ifdef. With a separate function, it can be single #ifdef.
> That is my point.
>
If CONFIG_OF isn't defined, compiler will select a static inline function that
just returns -ENODEV [1], so I think you don't need a #ifdef chunk here.
[1] https://elixir.bootlin.com/linux/latest/source/include/linux/of_net.h#L27
next prev parent reply other threads:[~2024-02-07 5:58 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-02 12:10 [PATCH 0/9] rtw88: Add support for RTL8723CS/RTL8703B Fiona Klute
2024-02-02 12:10 ` [PATCH 1/9] wifi: rtw88: Shared module for rtw8723x devices Fiona Klute
2024-02-03 14:20 ` kernel test robot
2024-02-03 15:04 ` kernel test robot
2024-02-03 21:47 ` kernel test robot
2024-02-04 10:03 ` kernel test robot
2024-02-05 1:45 ` Ping-Ke Shih
2024-02-05 16:47 ` Fiona Klute
2024-02-06 0:59 ` Ping-Ke Shih
2024-02-02 12:10 ` [PATCH 2/9] wifi: rtw88: Debug output for rtw8723x EFUSE Fiona Klute
2024-02-05 2:17 ` Ping-Ke Shih
2024-02-05 17:10 ` Fiona Klute
2024-02-02 12:10 ` [PATCH 3/9] wifi: rtw88: Add definitions for 8703b chip Fiona Klute
2024-02-02 12:10 ` [PATCH 4/9] wifi: rtw88: Add rtw8703b.h Fiona Klute
2024-02-05 2:24 ` Ping-Ke Shih
2024-02-06 1:08 ` Fiona Klute
2024-02-06 2:02 ` Ping-Ke Shih
2024-02-02 12:10 ` [PATCH 5/9] wifi: rtw88: Add rtw8703b.c Fiona Klute
2024-02-05 3:01 ` Ping-Ke Shih
2024-02-05 19:06 ` Fiona Klute
2024-02-06 1:37 ` Ping-Ke Shih
2024-02-06 8:12 ` Pavel Machek
2024-02-07 5:58 ` Ping-Ke Shih [this message]
2024-02-02 12:10 ` [PATCH 6/9] wifi: rtw88: Add rtw8703b_tables.h Fiona Klute
2024-02-02 12:10 ` [PATCH 7/9] wifi: rtw88: Add rtw8703b_tables.c Fiona Klute
2024-02-02 12:10 ` [PATCH 8/9] wifi: rtw88: Reset 8703b firmware before download Fiona Klute
2024-02-05 3:05 ` Ping-Ke Shih
2024-02-02 12:10 ` [PATCH 9/9] wifi: rtw88: SDIO device driver for RTL8723CS Fiona Klute
2024-02-05 3:10 ` Ping-Ke Shih
2024-02-05 16:07 ` Ulf Hansson
2024-02-02 13:13 ` [PATCH 0/9] rtw88: Add support for RTL8723CS/RTL8703B Dmitry Antipov
2024-02-02 13:27 ` Fiona Klute
2024-02-02 13:54 ` Dmitry Antipov
2024-02-02 14:13 ` Fiona Klute
2024-02-02 20:19 ` Pavel Machek
2024-02-03 0:36 ` Fiona Klute
2024-02-02 20:44 ` Pavel Machek
2024-02-02 20:52 ` Pavel Machek
2024-02-03 11:33 ` Fiona Klute
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96b723081b434800b91abaedf1df14a8@realtek.com \
--to=pkshih@realtek.com \
--cc=fiona.klute@gmx.de \
--cc=kvalo@kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=megi@xff.cz \
--cc=pavel@ucw.cz \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).