From: Krzysztof Kozlowski <krzk@kernel.org>
To: Yang Xiwen <forbidden405@outlook.com>,
kernel test robot <lkp@intel.com>,
Yang Xiwen via B4 Relay
<devnull+forbidden405.outlook.com@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Jaehoon Chung <jh80.chung@samsung.com>,
Rob Herring <robh+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: oe-kbuild-all@lists.linux.dev,
Igor Opaniuk <igor.opaniuk@linaro.org>,
tianshuliang <tianshuliang@hisilicon.com>,
David Yang <mmyangfl@gmail.com>,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/3] mmc: dw_mmc: add support for hi3798mv200
Date: Mon, 19 Feb 2024 13:27:09 +0100 [thread overview]
Message-ID: <956ebf94-62ef-4e67-893e-86586a980883@kernel.org> (raw)
In-Reply-To: <SEZPR06MB695945299705B6E8BF0E326296522@SEZPR06MB6959.apcprd06.prod.outlook.com>
On 18/02/2024 09:21, Yang Xiwen wrote:
> On 2/18/2024 4:03 PM, kernel test robot wrote:
>> Hi Yang,
>>
>> kernel test robot noticed the following build errors:
>>
>> [auto build test ERROR on 8d3dea210042f54b952b481838c1e7dfc4ec751d]
>>
>> url: https://github.com/intel-lab-lkp/linux/commits/Yang-Xiwen-via-B4-Relay/mmc-dw_mmc-add-support-for-hi3798mv200/20240216-014744
>> base: 8d3dea210042f54b952b481838c1e7dfc4ec751d
>> patch link: https://lore.kernel.org/r/20240216-b4-mmc-hi3798mv200-v1-1-7d46db845ae6%40outlook.com
>> patch subject: [PATCH 1/3] mmc: dw_mmc: add support for hi3798mv200
>> config: parisc-allyesconfig (https://download.01.org/0day-ci/archive/20240218/202402181540.H4Ose96P-lkp@intel.com/config)
>> compiler: hppa-linux-gcc (GCC) 13.2.0
>> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240218/202402181540.H4Ose96P-lkp@intel.com/reproduce)
>>
>> If you fix the issue in a separate patch/commit (i.e. not just a new version of
>> the same patch/commit), kindly add following tags
>> | Reported-by: kernel test robot <lkp@intel.com>
>> | Closes: https://lore.kernel.org/oe-kbuild-all/202402181540.H4Ose96P-lkp@intel.com/
>>
>> All errors (new ones prefixed by >>):
>>
>> drivers/mmc/host/dw_mmc-hi3798mv200.c: In function 'dw_mci_hi3798mv200_init':
>>>> drivers/mmc/host/dw_mmc-hi3798mv200.c:178:36: error: passing argument 1 of 'mmc_of_parse_clk_phase' from incompatible pointer type [-Werror=incompatible-pointer-types]
>> 178 | mmc_of_parse_clk_phase(host->dev, &priv->phase_map);
>> | ~~~~^~~~~
>> | |
>> | struct device *
>> In file included from drivers/mmc/host/dw_mmc-hi3798mv200.c:11:
>> include/linux/mmc/host.h:542:46: note: expected 'struct mmc_host *' but argument is of type 'struct device *'
>> 542 | void mmc_of_parse_clk_phase(struct mmc_host *host,
>> | ~~~~~~~~~~~~~~~~~^~~~
>> cc1: some warnings being treated as errors
>>
>>
>> vim +/mmc_of_parse_clk_phase +178 drivers/mmc/host/dw_mmc-hi3798mv200.c
>>
>> 168
>> 169 static int dw_mci_hi3798mv200_init(struct dw_mci *host)
>> 170 {
>> 171 struct dw_mci_hi3798mv200_priv *priv;
>> 172 struct device_node *np = host->dev->of_node;
>> 173
>> 174 priv = devm_kzalloc(host->dev, sizeof(*priv), GFP_KERNEL);
>> 175 if (!priv)
>> 176 return -ENOMEM;
>> 177
>> > 178 mmc_of_parse_clk_phase(host->dev, &priv->phase_map);
>
> Please note that this patch is depending on another patch[1].
>
> [1]:
> https://lore.kernel.org/linux-mmc/ae876e697ba16ba2925ec217c6b4e3d8ffea4ab3.camel@codeconstruct.com.au/T/#t
>
You did not provide any links to dependencies in cover letter nor in
patch changelog. You included on purpose, which is nice and correct, the
base commit:
base-commit: 8d3dea210042f54b952b481838c1e7dfc4ec751d
which does not include above commit apparently.
How anyone can guess it and test your patches?
Please send with proper dependencies marked.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-02-19 12:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 17:46 [PATCH 0/3] mmc: add hi3798mv200 specific extensions of DWMMC Yang Xiwen via B4 Relay
2024-02-15 17:46 ` [PATCH 1/3] mmc: dw_mmc: add support for hi3798mv200 Yang Xiwen via B4 Relay
2024-02-15 19:15 ` Krzysztof Kozlowski
2024-02-15 19:20 ` Yang Xiwen
2024-02-18 8:03 ` kernel test robot
2024-02-18 8:21 ` Yang Xiwen
2024-02-19 12:27 ` Krzysztof Kozlowski [this message]
2024-02-18 22:11 ` kernel test robot
2024-02-15 17:46 ` [PATCH 2/3] dt-bindings: mmc: dw-mshc-hi3798cv200: convert to YAML Yang Xiwen via B4 Relay
2024-02-16 8:19 ` Krzysztof Kozlowski
2024-02-16 8:33 ` Yang Xiwen
2024-02-15 17:46 ` [PATCH 3/3] dt-bindings: mmc: dw-mshc-hi3798cv200: rename to dw-mshc-histb Yang Xiwen via B4 Relay
2024-02-16 8:21 ` Krzysztof Kozlowski
2024-02-16 8:29 ` Yang Xiwen
2024-02-16 8:41 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=956ebf94-62ef-4e67-893e-86586a980883@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=devnull+forbidden405.outlook.com@kernel.org \
--cc=forbidden405@outlook.com \
--cc=igor.opaniuk@linaro.org \
--cc=jh80.chung@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mmyangfl@gmail.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=robh+dt@kernel.org \
--cc=tianshuliang@hisilicon.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).