From: Dragan Simic <dsimic@manjaro.org>
To: Yao Xiao <xiaokeqinhealth@126.com>
Cc: ulf.hansson@linaro.org, linux-mmc@vger.kernel.org,
Avri Altman <avri.altman@wdc.com>
Subject: Re: [PATCH v3 1/1] mmc: core: increase the timeout period of the ACMD41 command.
Date: Mon, 29 Apr 2024 09:22:57 +0200 [thread overview]
Message-ID: <84689df7c67c49e4626450f92e878f12@manjaro.org> (raw)
In-Reply-To: <34190ce8-622c-4dd7-9686-1d53b1a343ce@126.com>
On 2024-04-29 09:19, Yao Xiao wrote:
> On 2024/4/29 15:09, Dragan Simic wrote:
>> On 2024-04-29 08:38, Felix Qin wrote:
>>> Extensive testing has shown that some specific SD cards require an
>>> increased command timeout to be successfully initialized.
>>>
>>> More info:
>>> Platform: Rockchip SoC + DW Multimedia host Controller
>>> SD card: Xvv microSD CMH34A17TMA12 (Made in Korea)
>>> Note: The SD card is custom-made by the customer in collaboration
>>> with the wafer foundry.
>>>
>>> Signed-off-by: Felix Qin <xiaokeqinhealth@126.com>
>>> Acked-by: Avri Altman <avri.altman@wdc.com>
>>> Reviewed-by: Dragan Simic <dsimic@manjaro.org>
>>
>> Huh, the v3 looks nowhere like the v2, so please consider
>> my Reviewed-by tag revoked until I get some time to check what
>> actually happened to the patch.
>
> I apologize for the inconvenience caused, and I will resend the patch.
No worries. I'll go through the v3 and the associated Ulf's
patch a bit later.
>>> ---
>>> v2: Add more info
>>> v3: Based on the __mmc_poll_for_busy API for modification
>>> ---
>>> drivers/mmc/core/sd_ops.c | 7 ++++++-
>>> 1 file changed, 6 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/mmc/core/sd_ops.c b/drivers/mmc/core/sd_ops.c
>>> index 3ce1ff336826..a1c028303ba7 100644
>>> --- a/drivers/mmc/core/sd_ops.c
>>> +++ b/drivers/mmc/core/sd_ops.c
>>> @@ -19,8 +19,13 @@
>>> #include "sd_ops.h"
>>> #include "mmc_ops.h"
>>>
>>> +/*
>>> + * Extensive testing has shown that some specific SD cards
>>> + * require an increased command timeout to be successfully
>>> + * initialized.
>>> + */
>>> #define SD_APP_OP_COND_PERIOD_US (10 * 1000) /* 10ms */
>>> -#define SD_APP_OP_COND_TIMEOUT_MS 1000 /* 1s */
>>> +#define SD_APP_OP_COND_TIMEOUT_MS 2000 /* 2s */
>>>
>>> struct sd_app_op_cond_busy_data {
>>> struct mmc_host *host;
next prev parent reply other threads:[~2024-04-29 7:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 6:38 [PATCH v3 1/1] mmc: core: increase the timeout period of the ACMD41 command Felix Qin
2024-04-29 7:09 ` Dragan Simic
2024-04-29 7:19 ` Yao Xiao
2024-04-29 7:22 ` Dragan Simic [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-04-29 7:19 Felix Qin
2024-04-29 19:38 ` Avri Altman
2024-04-30 1:27 ` Dragan Simic
2024-05-03 13:14 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84689df7c67c49e4626450f92e878f12@manjaro.org \
--to=dsimic@manjaro.org \
--cc=avri.altman@wdc.com \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=xiaokeqinhealth@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).