From: Linus Walleij <linus.walleij@linaro.org>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Ming Lei <ming.lei@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
Ulf Hansson <ulf.hansson@linaro.org>,
Nicolas Pitre <nico@fluxnic.net>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
Adrian Hunter <adrian.hunter@intel.com>,
Angelo Dureghello <angelo.dureghello@timesys.com>
Cc: linux-mmc@vger.kernel.org, linux-block@vger.kernel.org,
linux-omap@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>
Subject: [PATCH 0/7] mmc: Try to do proper kmap_local() for scatterlists
Date: Thu, 25 Jan 2024 15:37:04 +0100 [thread overview]
Message-ID: <20240125-mmc-proper-kmap-v1-0-ba953c1ac3f9@linaro.org> (raw)
It was brought to our attention that some MMC host drivers
are referencing sg_virt(sg) directly on scatterlist entries,
which will not perform buffer bouncing for CONFIG_HIGHMEM
pages that reside in highmem.
See the following mail from Christoph and the discussion:
https://lore.kernel.org/linux-mmc/20240122073423.GA25859@lst.de/
This means that bugs with highmem pages can go unnoticed
until an actual highmem page is finally used and not bounced,
resulting in things like unpredictable file corruption.
Attempt to fix this by amending all host controllers
calling sg_virt() for PIO to instead do proper mapping
and unmapping of the scatterlist entry, possibly bouncing
it from highmem if need be.
More complicated patches are possible, the most obvious
to rewrite the PIO loops to use sg_miter_[start|next|stop]()
see for example mmci.c, but I leave this refactoring as
a suggestion to each device driver maintainer because I
can't really test the patches.
All patches are compile-tested except the m68k one,
sdhci-esdhc-mcf.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
Linus Walleij (7):
mmc: davinci_mmc: Map the virtual page for PIO
mmc: moxart-mmc: Map the virtual page for PIO
mmc: mvsdio: Map the virtual page for PIO
mmc: mxcmmc: Map the virtual page for PIO
mmc: omap: Map the virtual page for PIO
mmc: sdhci-esdhc-mcf: Map the virtual page for swapping
mmc: sh_mmcif: Map the virtual page for PIO
drivers/mmc/host/davinci_mmc.c | 10 ++++++++--
drivers/mmc/host/moxart-mmc.c | 3 ++-
drivers/mmc/host/mvsdio.c | 3 ++-
drivers/mmc/host/mxcmmc.c | 23 +++++++++++++++--------
drivers/mmc/host/omap.c | 7 ++++++-
drivers/mmc/host/sdhci-esdhc-mcf.c | 3 ++-
drivers/mmc/host/sh_mmcif.c | 22 ++++++++++++++++++----
7 files changed, 53 insertions(+), 18 deletions(-)
---
base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d
change-id: 20240125-mmc-proper-kmap-f2d4cf5d1756
Best regards,
--
Linus Walleij <linus.walleij@linaro.org>
next reply other threads:[~2024-01-25 14:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-25 14:37 Linus Walleij [this message]
2024-01-25 14:37 ` [PATCH 1/7] mmc: davinci_mmc: Map the virtual page for PIO Linus Walleij
2024-01-25 16:37 ` Arnd Bergmann
2024-01-25 23:18 ` Linus Walleij
2024-01-25 14:37 ` [PATCH 2/7] mmc: moxart-mmc: " Linus Walleij
2024-01-25 14:37 ` [PATCH 3/7] mmc: mvsdio: " Linus Walleij
2024-01-25 14:37 ` [PATCH 4/7] mmc: mxcmmc: " Linus Walleij
2024-01-25 14:37 ` [PATCH 5/7] mmc: omap: " Linus Walleij
2024-01-25 14:37 ` [PATCH 6/7] mmc: sdhci-esdhc-mcf: Map the virtual page for swapping Linus Walleij
2024-01-25 14:37 ` [PATCH 7/7] mmc: sh_mmcif: Map the virtual page for PIO Linus Walleij
2024-02-13 16:45 ` [PATCH 0/7] mmc: Try to do proper kmap_local() for scatterlists Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240125-mmc-proper-kmap-v1-0-ba953c1ac3f9@linaro.org \
--to=linus.walleij@linaro.org \
--cc=aaro.koskinen@iki.fi \
--cc=adrian.hunter@intel.com \
--cc=angelo.dureghello@timesys.com \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=nico@fluxnic.net \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).