From: Stefan Wahren <wahrenst@gmx.net>
To: Andrea della Porta <andrea.porta@suse.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Kamal Dasu <kamal.dasu@broadcom.com>,
Al Cooper <alcooperx@gmail.com>, Eric Anholt <eric@anholt.net>,
devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH v2 2/4] dt-bindings: mmc: Add support for BCM2712 SD host controller
Date: Fri, 10 May 2024 21:01:33 +0200 [thread overview]
Message-ID: <01a7a263-9de3-468c-b438-c16f2c73872c@gmx.net> (raw)
In-Reply-To: <1f0c4fa62d6849753e2138cce5498693cfc3a230.1715332922.git.andrea.porta@suse.com>
Hi Andrea,
please drop E. Anholt from the recipients. AFAIK she is not interested
in kernel development anymore.
Am 10.05.24 um 16:35 schrieb Andrea della Porta:
> The BCM2712 has an SDHCI capable host interface similar to the one found
> in other STB chipsets. Add the relevant compatible string and relative
> example.
>
> Signed-off-by: Andrea della Porta <andrea.porta@suse.com>
> ---
> .../bindings/mmc/brcm,sdhci-brcmstb.yaml | 23 +++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
> index cbd3d6c6c77f..404b75fa7adb 100644
> --- a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
> +++ b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
> @@ -13,6 +13,10 @@ maintainers:
> properties:
> compatible:
> oneOf:
> + - items:
> + - enum:
> + - brcm,bcm2712-sdhci
> + - const: brcm,sdhci-brcmstb
> - items:
> - enum:
> - brcm,bcm7216-sdhci
> @@ -114,3 +118,22 @@ examples:
> clocks = <&scmi_clk 245>;
> clock-names = "sw_sdio";
> };
> +
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
Would be nice to have a short explanation in the commit message why this
is necessary.
> +
> + mmc@1000fff000 {
> + compatible = "brcm,bcm2712-sdhci",
> + "brcm,sdhci-brcmstb";
> + reg = <0x10 0x00fff000 0x0 0x260>,
> + <0x10 0x00fff400 0x0 0x200>;
> + reg-names = "host", "cfg";
> + mmc-ddr-3_3v;
> + interrupts = <GIC_SPI 0x111 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clk_emmc2>;
> + clock-names = "sw_sdio";
> + };
> + };
next prev parent reply other threads:[~2024-05-10 19:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 14:35 [PATCH v2 0/4] Add minimal boot support for Raspberry Pi 5 Andrea della Porta
2024-05-10 14:35 ` [PATCH v2 1/4] dt-bindings: arm: bcm: Add BCM2712 SoC support Andrea della Porta
2024-05-10 18:40 ` Stefan Wahren
2024-05-10 21:33 ` Conor Dooley
2024-05-20 13:37 ` Krzysztof Kozlowski
2024-05-10 14:35 ` [PATCH v2 2/4] dt-bindings: mmc: Add support for BCM2712 SD host controller Andrea della Porta
2024-05-10 19:01 ` Stefan Wahren [this message]
2024-05-13 18:58 ` Rob Herring
2024-05-10 14:35 ` [PATCH v2 3/4] mmc: sdhci-brcmstb: Add BCM2712 support Andrea della Porta
2024-05-10 19:22 ` Stefan Wahren
2024-05-10 14:35 ` [PATCH v2 4/4] arm64: dts: broadcom: Add support for BCM2712 Andrea della Porta
2024-05-10 16:13 ` Marc Zyngier
2024-05-10 16:14 ` Florian Fainelli
2024-05-16 8:36 ` Andrea della Porta
2024-05-20 18:03 ` Florian Fainelli
2024-05-10 19:43 ` Stefan Wahren
2024-05-13 13:27 ` [PATCH v2 0/4] Add minimal boot support for Raspberry Pi 5 Rob Herring (Arm)
2024-05-16 10:32 ` Andrea della Porta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01a7a263-9de3-468c-b438-c16f2c73872c@gmx.net \
--to=wahrenst@gmx.net \
--cc=adrian.hunter@intel.com \
--cc=alcooperx@gmail.com \
--cc=andrea.porta@suse.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eric@anholt.net \
--cc=florian.fainelli@broadcom.com \
--cc=kamal.dasu@broadcom.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=rjui@broadcom.com \
--cc=robh@kernel.org \
--cc=sbranden@broadcom.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).