From: Yujie Liu <yujie.liu@intel.com>
To: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: "kernel test robot" <lkp@intel.com>,
oe-kbuild-all@lists.linux.dev,
"Linux Memory Management List" <linux-mm@kvack.org>,
"Hans de Goede" <hdegoede@redhat.com>,
"Zhang Rui" <rui.zhang@intel.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: Re: [linux-next:master 8353/12793] drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.o: warning: objtool: map_partition_power_domain_id() falls through to next function get_instance()
Date: Wed, 15 May 2024 10:23:30 +0800 [thread overview]
Message-ID: <ZkQcogwAcpUPo+Mb@yujie-X299> (raw)
In-Reply-To: <2880b55bbe08e3ef7762b47b3531cd29f785eedd.camel@linux.intel.com>
On Tue, May 14, 2024 at 11:00:50AM -0700, srinivas pandruvada wrote:
> On Tue, 2024-05-14 at 14:05 +0800, kernel test robot wrote:
> > tree:
> > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git m
> > aster
> > head: 6ba6c795dc73c22ce2c86006f17c4aa802db2a60
> > commit: 9d1d36268f3d8276aefd1fad4e0a415dc8c36edd [8353/12793]
> > platform/x86: ISST: Support partitioned systems
> > config: x86_64-randconfig-101-20240514
> > (https://download.01.org/0day-ci/archive/20240514/202405141321.RQmski
> > Tj-lkp@intel.com/config)
> > compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
[...]
> > reproduce (this is a W=1 build):
> > (https://download.01.org/0day-ci/archive/20240514/202405141321.RQmski
> > Tj-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new
> > version of
> > the same patch/commit), kindly add following tags
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > Closes:
> > > https://lore.kernel.org/oe-kbuild-all/202405141321.RQmskiTj-lkp@intel.com/
> >
> > All warnings (new ones prefixed by >>):
> >
> > > > drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.o:
> > > > warning: objtool: map_partition_power_domain_id() falls through
> > > > to next function get_instance()
> >
>
> Not able to reproduce on two gcc versions on Fedora and Ubuntu
> distribution.
> gcc --version
> gcc (GCC) 13.2.1 20240316 (Red Hat 13.2.1-7)
>
> gcc --version
> gcc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
We tried various versions of gcc on Ubuntu distribution and found
that only "gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0" can reproduce it, while
other newer versions cannot, so this may be a gcc-7 bug. Please ignore
it and we will configure the bot to skip this particular "function falls
through" warning for gcc-7.
Thanks,
Yujie
>
>
> The documentation for this error:
> https://elixir.bootlin.com/linux/latest/source/tools/objtool/Documentation/objtool.txt
>
> "
> 8. file.o: warning: objtool: funcA() falls through to next function
> funcB()
>
> This means that funcA() doesn't end with a return instruction or an
> unconditional jump, and that objtool has determined that the function
> can fall through into the next function.
>
> "
>
> This function ends with " return -EINVAL;"
>
> Also the three reasons in the documentation is also not met.
>
>
>
> make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
> make[1]: Entering directory '/home/spandruv/development/linux-
> next/build_dir'
> GEN Makefile
> CALL ../scripts/checksyscalls.sh
> DESCEND objtool
> INSTALL libsubcmd_headers
> DESCEND bpf/resolve_btfids
> INSTALL libsubcmd_headers
> CHK kernel/kheaders_data.tar.xz
> CC [M] drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.o
> MODPOST Module.symvers
> ...
>
> TEST posttest
> arch/x86/tools/insn_decoder_test: success: Decoded and checked 8715543
> instructions
> TEST posttest
> arch/x86/tools/insn_sanity: Success: decoded and checked 1000000 random
> instructions with 0 errors (seed:0x5e80fa20)
> Kernel: arch/x86/boot/bzImage is ready (#1)
> LD [M] drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.ko
> BTF [M] drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.ko
> ..
> make[1]: Leaving directory '/home/spandruv/development/linux-
> next/build_dir'
>
>
> Thanks,
> Srinivas
>
>
prev parent reply other threads:[~2024-05-15 2:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-14 6:05 [linux-next:master 8353/12793] drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.o: warning: objtool: map_partition_power_domain_id() falls through to next function get_instance() kernel test robot
2024-05-14 18:00 ` srinivas pandruvada
2024-05-15 2:23 ` Yujie Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZkQcogwAcpUPo+Mb@yujie-X299 \
--to=yujie.liu@intel.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).