From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C632C47095 for ; Wed, 9 Jun 2021 06:44:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EC96D61249 for ; Wed, 9 Jun 2021 06:44:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC96D61249 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 258DD6B0036; Wed, 9 Jun 2021 02:44:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 231C86B006E; Wed, 9 Jun 2021 02:44:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D18F6B0070; Wed, 9 Jun 2021 02:44:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D1B606B0036 for ; Wed, 9 Jun 2021 02:44:20 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 5D5EA181AEF2A for ; Wed, 9 Jun 2021 06:44:20 +0000 (UTC) X-FDA: 78233246280.19.002A5BC Received: from mail-vs1-f54.google.com (mail-vs1-f54.google.com [209.85.217.54]) by imf19.hostedemail.com (Postfix) with ESMTP id AB0F29001E64 for ; Wed, 9 Jun 2021 06:44:15 +0000 (UTC) Received: by mail-vs1-f54.google.com with SMTP id x13so3878216vsf.11 for ; Tue, 08 Jun 2021 23:44:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=47baV1P3SWK5Bn+j5B4OfUEOCRj033QYxRPMFVA0Gg8=; b=dzgSZW7wn3FURdWa1Gx7YNnYSQQk1glzTmN25E24QGxyqJZIyKkFips4ATGMVmI4Ci 5ieyUP+Tc1teEdMOfRqUxQjzJv/XYe/Sfiy6kvqBioOISGl8mAZi5iOxLRI17Ex5eRJ+ FSbY57AoRoiGOEWmVxEX+ZHlcjGGt5UK4/lWI1mxncdg2mP1l+PZrZpzhQiwG+IDCFWk LqtmwEKSsV7xk2dfSiuXcYIig/dhnF5sUeo2b/yO4wLvPZtndEnbwbnccdEE4rnayqUf dK+fnd0EAmmVmcNqqneFjBcbAiYRRaUPZl2A4as7/4MAcc3UvdC4dKf2D4AkRJxP2XcL NjHg== X-Gm-Message-State: AOAM532H20RQqwsJqRBykTojp1NYKwOVBEG4nhX4POFBr3JWeNA9S0RL t98FwruELJJJ00IKxP7/4ABtnfLR+30Y5/6RShs= X-Google-Smtp-Source: ABdhPJxgZoIMbN5GFh2VWpL6EzDYRXy63LPTY3UqoHKfLRG9A/qZOe2ycSYBUB4Pbup17C6x2oVs/4epAGglyIbvzWw= X-Received: by 2002:a67:efd6:: with SMTP id s22mr3458501vsp.3.1623221059463; Tue, 08 Jun 2021 23:44:19 -0700 (PDT) MIME-Version: 1.0 References: <1623214799-29817-1-git-send-email-anshuman.khandual@arm.com> In-Reply-To: <1623214799-29817-1-git-send-email-anshuman.khandual@arm.com> From: Geert Uytterhoeven Date: Wed, 9 Jun 2021 08:44:08 +0200 Message-ID: Subject: Re: [PATCH V2] mm/thp: Define default pmd_pgtable() To: Anshuman Khandual Cc: Linux MM , Andrew Morton , Nick Hu , Richard Henderson , Vineet Gupta , Catalin Marinas , Will Deacon , Guo Ren , Brian Cain , Michal Simek , Thomas Bogendoerfer , Ley Foon Tan , Jonas Bonn , Stefan Kristiansson , Stafford Horne , "James E.J. Bottomley" , Michael Ellerman , Christophe Leroy , Paul Walmsley , Palmer Dabbelt , Heiko Carstens , Yoshinori Sato , "David S. Miller" , Jeff Dike , Thomas Gleixner , Chris Zankel , Linux-Arch , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: AB0F29001E64 X-Stat-Signature: qx1t7gchkq6gmuqa9ts86xjr87b7mqjx Authentication-Results: imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of geertuytterhoeven@gmail.com designates 209.85.217.54 as permitted sender) smtp.mailfrom=geertuytterhoeven@gmail.com; dmarc=none X-HE-Tag: 1623221055-919323 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Anshuman, On Wed, Jun 9, 2021 at 6:59 AM Anshuman Khandual wrote: > Currently most platforms define pmd_pgtable() as pmd_page() duplicating the > same code all over. Instead just define a default value i.e pmd_page() for > pmd_pgtable() and let platforms override when required via . > All the existing platform that override pmd_pgtable() have been moved into > their respective header in order to precede before the new > generic definition. This makes it much cleaner with reduced code. > Signed-off-by: Anshuman Khandual > --- > This patch applies on linux-next (20210608) as there is a merge conflict > dependency on the following commit. > > 40762590e8be ("mm: define default value for FIRST_USER_ADDRESS"). > > This patch has been built tested across multiple platforms. > > Changes in V2: > > - Changed m68k per Geert Thanks for the update! > arch/m68k/include/asm/mcf_pgalloc.h | 2 -- > arch/m68k/include/asm/mcf_pgtable.h | 2 ++ > arch/m68k/include/asm/motorola_pgalloc.h | 1 - > arch/m68k/include/asm/motorola_pgtable.h | 2 ++ > arch/m68k/include/asm/sun3_pgalloc.h | 1 - > arch/m68k/include/asm/sun3_pgtable.h | 2 ++ Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds