From: Suren Baghdasaryan <surenb@google.com>
To: Kees Cook <keescook@chromium.org>
Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev,
pasha.tatashin@soleen.com, vbabka@suse.cz, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] lib: add version into /proc/allocinfo output
Date: Tue, 14 May 2024 13:19:19 -0700 [thread overview]
Message-ID: <CAJuCfpGjRtL4nrOp2fLVM2=Yfg2WH4DXjkTK-y_1q4uwAxFDHg@mail.gmail.com> (raw)
In-Reply-To: <202405140957.92089A615@keescook>
On Tue, May 14, 2024 at 9:58 AM Kees Cook <keescook@chromium.org> wrote:
>
> On Tue, May 14, 2024 at 09:31:28AM -0700, Suren Baghdasaryan wrote:
> > Add version string and a header at the beginning of /proc/allocinfo to
> > allow later format changes. Example output:
> >
> > > head /proc/allocinfo
> > allocinfo - version: 1.0
> > # <size> <calls> <tag info>
> > 0 0 init/main.c:1314 func:do_initcalls
> > 0 0 init/do_mounts.c:353 func:mount_nodev_root
> > 0 0 init/do_mounts.c:187 func:mount_root_generic
> > 0 0 init/do_mounts.c:158 func:do_mount_root
> > 0 0 init/initramfs.c:493 func:unpack_to_rootfs
> > 0 0 init/initramfs.c:492 func:unpack_to_rootfs
> > 0 0 init/initramfs.c:491 func:unpack_to_rootfs
> > 512 1 arch/x86/events/rapl.c:681 func:init_rapl_pmus
> > 128 1 arch/x86/events/rapl.c:571 func:rapl_cpu_online
> >
> > Signed-off-by: Suren Baghdasaryan <surenb@google.com>
>
> Ah yeah, good idea. (Do we have versioning like this anywhere else in
> our /proc files? It seems a nice thing to add...)
Yes, /proc/slabinfo has a similar header that includes a version number.
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
Thanks!
>
> --
> Kees Cook
prev parent reply other threads:[~2024-05-14 20:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-14 16:31 [PATCH v2 1/1] lib: add version into /proc/allocinfo output Suren Baghdasaryan
2024-05-14 16:35 ` Pasha Tatashin
2024-05-14 16:58 ` Kees Cook
2024-05-14 20:19 ` Suren Baghdasaryan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJuCfpGjRtL4nrOp2fLVM2=Yfg2WH4DXjkTK-y_1q4uwAxFDHg@mail.gmail.com' \
--to=surenb@google.com \
--cc=akpm@linux-foundation.org \
--cc=keescook@chromium.org \
--cc=kent.overstreet@linux.dev \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pasha.tatashin@soleen.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).