From: SeongJae Park <sj@kernel.org>
To: Honggyu Kim <honggyu.kim@sk.com>
Cc: SeongJae Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Steven Rostedt <rostedt@goodmis.org>,
damon@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org,
Hyeongtak Ji <hyeongtak.ji@sk.com>, Rakie Kim <rakie.kim@sk.com>,
kernel_team@skhynix.com
Subject: Re: [RFC PATCH v4 0/5] DAMON based tiered memory management for CXL memory
Date: Wed, 15 May 2024 09:18:35 -0700 [thread overview]
Message-ID: <20240515161835.69311-1-sj@kernel.org> (raw)
In-Reply-To: <20240513115918.1479-1-honggyu.kim@sk.com>
Hi Honggyu,
On Mon, 13 May 2024 20:59:15 +0900 Honggyu Kim <honggyu.kim@sk.com> wrote:
> Hi SeongJae,
>
> Thanks very much for your work! It got delayed due to the priority
> changes in my workplace for building another heterogeneous memory
> allocator.
> https://github.com/skhynix/hmsdk/wiki/hmalloc
No problem at all. We all work on our own schedule and nobody can chase/push
anybody :)
>
> On Sun, 12 May 2024 10:54:42 -0700 SeongJae Park <sj@kernel.org> wrote:
> > There was an RFC IDEA "DAMOS-based Tiered-Memory Management" previously
> > posted at [1].
> >
> > It says there is no implementation of the demote/promote DAMOS action
> > are made. This RFC is about its implementation for physical address
> > space.
> >
> > Changes from RFC v3
> > (https://lore.kernel.org/20240405060858.2818-1-honggyu.kim@sk.com):
>
> This link cannot be opened. I will share the link again here.
> https://lore.kernel.org/all/20240405060858.2818-1-honggyu.kim@sk.com
Thank you for checking the link! It's weird though, since I can open the link
on my Chrome browser.
>
> > 0. updated from v3 and posted by SJ on behalf of Hunggyu under his
> > approval.
> > 1. Do not reuse damon_pa_pageout() and drop 'enum migration_mode'
> > 2. Drop vmstat change
>
> I haven't checked whether I can collect useful information without
> vmstat, but the changes look good in general except for that.
I was thinking you could use DAMOS stat[1] for the schemes and assuming no
reply to it as an agreement, but maybe I should made it clear. Do you think
DAMOS stat cannot be used instead? If so, what would be the limitation of
DAMOS stat for your usage?
>
> > 3. Drop unnecessary page reference check
>
> I will compare this patch series with my previous v3 patchset and get
> back to you later maybe next week.
Thank you very much! Unless I get a good enough test setup and results from it
on my own or from others' help, your test result would be the last requirement
for dropping RFC from this patchset.
> Sorry, I will have another break this week.
No problem, I hope you to have nice break. Nobody can chase/push others. We
all do this work voluntarily for our own fun and profit, right? ;)
[1] https://lore.kernel.org/damon/20240405060858.2818-1-honggyu.kim@sk.com
Thanks,
SJ
>
> Thanks,
> Honggyu
prev parent reply other threads:[~2024-05-15 16:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-12 17:54 [RFC PATCH v4 0/5] DAMON based tiered memory management for CXL memory SeongJae Park
2024-05-12 17:54 ` [RFC PATCH v4 1/5] mm: make alloc_demote_folio externally invokable for migration SeongJae Park
2024-05-13 12:03 ` Honggyu Kim
2024-05-15 16:10 ` SeongJae Park
2024-05-12 17:54 ` [RFC PATCH v4 2/5] mm/damon/sysfs-schemes: add target_nid on sysfs-schemes SeongJae Park
2024-05-12 17:54 ` [RFC PATCH v4 3/5] mm/migrate: add MR_DAMON to migrate_reason SeongJae Park
2024-05-12 17:54 ` [RFC PATCH v4 4/5] mm/damon/paddr: introduce DAMOS_MIGRATE_COLD action for demotion SeongJae Park
2024-05-12 17:54 ` [RFC PATCH v4 5/5] mm/damon/paddr: introduce DAMOS_MIGRATE_HOT action for promotion SeongJae Park
2024-05-13 11:59 ` [RFC PATCH v4 0/5] DAMON based tiered memory management for CXL memory Honggyu Kim
2024-05-15 16:18 ` SeongJae Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240515161835.69311-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=honggyu.kim@sk.com \
--cc=hyeongtak.ji@sk.com \
--cc=kernel_team@skhynix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rakie.kim@sk.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).