From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Yury Norov <yury.norov@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-mips@vger.kernel.org
Subject: Re: [PATCH] MIPS: SGI-IP30: Use bitmap API when iterating over bitmap
Date: Thu, 18 Apr 2024 15:37:58 +0200 [thread overview]
Message-ID: <fbbabdc6-2505-45d2-a46a-c80c1eca6ee8@linaro.org> (raw)
In-Reply-To: <ZiAGcb3eY/Nqamb9@yury-ThinkPad>
On 17/4/24 19:27, Yury Norov wrote:
> On Wed, Apr 17, 2024 at 09:18:29AM +0200, Philippe Mathieu-Daudé wrote:
>> Do not open-code bitmap_set(). Besides, <linux/bitmap.h> API
>> allows architecture specific optimizations, so prefer it.
>>
>> Use the HEART_NUM_IRQS definition to express the end of the
>> HEART bitmap.
>>
>> Inspired-by: Yury Norov <yury.norov@gmail.com>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> ---
>> arch/mips/sgi-ip30/ip30-irq.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/arch/mips/sgi-ip30/ip30-irq.c b/arch/mips/sgi-ip30/ip30-irq.c
>> index 423c32cb66ed..bdafff076191 100644
>> --- a/arch/mips/sgi-ip30/ip30-irq.c
>> +++ b/arch/mips/sgi-ip30/ip30-irq.c
>> @@ -264,7 +264,6 @@ void __init arch_init_irq(void)
>> struct irq_domain *domain;
>> struct fwnode_handle *fn;
>> unsigned long *mask;
>> - int i;
>>
>> mips_cpu_irq_init();
>>
>> @@ -300,8 +299,7 @@ void __init arch_init_irq(void)
>> set_bit(HEART_L3_INT_TIMER, heart_irq_map);
>>
>> /* Reserve the error interrupts (#51 to #63). */
>> - for (i = HEART_L4_INT_XWID_ERR_9; i <= HEART_L4_INT_HEART_EXCP; i++)
>> - set_bit(i, heart_irq_map);
>> + bitmap_set(heart_irq_map, HEART_L4_INT_XWID_ERR_9, HEART_NUM_IRQS);
>
> This function has a signature
> bitmap_set(map, start, length)
Doh, I thought it was (map, from_inc, to_exc), my bad.
> So this should be a:
> bitmap_set(heart_irq_map, HEART_L4_INT_XWID_ERR_9,
> HEART_NUM_IRQS - HEART_L4_INT_XWID_ERR_9 + 1)
>
> Also on the above group of set_bit(). It should be 2 bitmap_set()
> calls to me. HEART_L0_INT [0, 2] is the first one, and HEART_L2_INT
> to HEART_L4_INT [46, 63] is the other. Isn't?
Please disregard this patch, sorry for the noise.
Regards,
Phil.
prev parent reply other threads:[~2024-04-18 13:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 7:18 [PATCH] MIPS: SGI-IP30: Use bitmap API when iterating over bitmap Philippe Mathieu-Daudé
2024-04-17 11:13 ` Thomas Bogendoerfer
2024-04-17 17:27 ` Yury Norov
2024-04-18 13:37 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbbabdc6-2505-45d2-a46a-c80c1eca6ee8@linaro.org \
--to=philmd@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).