From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Yury Norov <yury.norov@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] MIPS: SGI-IP27: use WARN_ON() output
Date: Fri, 3 May 2024 14:50:40 +0200 [thread overview]
Message-ID: <ZjTdoLG+KH/qYF2l@alpha.franken.de> (raw)
In-Reply-To: <20240416173711.613750-3-yury.norov@gmail.com>
On Tue, Apr 16, 2024 at 10:37:11AM -0700, Yury Norov wrote:
> WARN_ON() propagates the result of conditional expression, and it can be
> used to return early in the following expression in the arch_init_irq().
>
> This is a no-op cleanup, except that compiler may optimize the error paths
> better because WARN_ON() implies 'unlikely()'.
>
> Signed-off-by: Yury Norov <yury.norov@gmail.com>
> ---
> arch/mips/sgi-ip27/ip27-irq.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/arch/mips/sgi-ip27/ip27-irq.c b/arch/mips/sgi-ip27/ip27-irq.c
> index d8acdf0439d2..00e63e9ef61d 100644
> --- a/arch/mips/sgi-ip27/ip27-irq.c
> +++ b/arch/mips/sgi-ip27/ip27-irq.c
> @@ -289,13 +289,12 @@ void __init arch_init_irq(void)
> bitmap_set(hub_irq_map, NI_BRDCAST_ERR_A, MSC_PANIC_INTR - NI_BRDCAST_ERR_A + 1);
>
> fn = irq_domain_alloc_named_fwnode("HUB");
> - WARN_ON(fn == NULL);
> - if (!fn)
> + if (WARN_ON(fn == NULL))
> return;
> +
> domain = irq_domain_create_linear(fn, IP27_HUB_IRQ_COUNT,
> &hub_domain_ops, NULL);
> - WARN_ON(domain == NULL);
> - if (!domain)
> + if (WARN_ON(domain == NULL))
> return;
>
> irq_set_default_host(domain);
> --
> 2.40.1
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2024-05-03 12:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 17:37 [PATCH 0/2] MIPS: SGI-IP27: micro-optimize arch_init_irq() Yury Norov
2024-04-16 17:37 ` [PATCH v2 1/2] " Yury Norov
2024-04-17 11:10 ` Thomas Bogendoerfer
2024-04-22 23:04 ` Yury Norov
2024-05-03 12:50 ` Thomas Bogendoerfer
2024-04-16 17:37 ` [PATCH 2/2] MIPS: SGI-IP27: use WARN_ON() output Yury Norov
2024-05-03 12:50 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjTdoLG+KH/qYF2l@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).