From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Yongzhen Zhang <zhangyongzhen@kylinos.cn>
Cc: hauke@hauke-m.de, zajec5@gmail.com, linux-mips@vger.kernel.org
Subject: Re: [PATCH] MIPS: BCM47XX: include header for bcm47xx_prom_highmem_init() prototype
Date: Mon, 15 Apr 2024 10:33:57 +0200 [thread overview]
Message-ID: <ZhzmdcpJaWIGu/zT@alpha.franken.de> (raw)
In-Reply-To: <20240315022923.178593-1-zhangyongzhen@kylinos.cn>
On Fri, Mar 15, 2024 at 10:29:23AM +0800, Yongzhen Zhang wrote:
> bcm47xx_prom_highmem_init() is a global function declared in
> arch/mips/bcm47xx/bcm47xx_private.h, but this header is not
> included before the definition, causing a error:
>
> arch/mips/bcm47xx/prom.c:134:13: error: no previous prototype for ‘bcm47xx_prom_highmem_init’ [-Werror=missing-prototypes]
> 134 | void __init bcm47xx_prom_highmem_init(void)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Yongzhen Zhang <zhangyongzhen@kylinos.cn>
> ---
> arch/mips/bcm47xx/prom.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/mips/bcm47xx/prom.c b/arch/mips/bcm47xx/prom.c
> index 99a1ba5394e0..7344a5eb990e 100644
> --- a/arch/mips/bcm47xx/prom.c
> +++ b/arch/mips/bcm47xx/prom.c
> @@ -35,6 +35,7 @@
> #include <asm/bootinfo.h>
> #include <bcm47xx.h>
> #include <bcm47xx_board.h>
> +#include "bcm47xx_private.h"
>
> static char bcm47xx_system_type[20] = "Broadcom BCM47XX";
>
> --
> 2.34.1
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2024-04-15 8:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 2:29 [PATCH] MIPS: BCM47XX: include header for bcm47xx_prom_highmem_init() prototype Yongzhen Zhang
2024-04-08 6:55 ` Philippe Mathieu-Daudé
2024-04-15 8:33 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZhzmdcpJaWIGu/zT@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=hauke@hauke-m.de \
--cc=linux-mips@vger.kernel.org \
--cc=zajec5@gmail.com \
--cc=zhangyongzhen@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).