From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Yongzhen Zhang <zhangyongzhen@kylinos.cn>
Cc: linux-mips@vger.kernel.org
Subject: Re: [PATCH] MIPS: RB532: Declare prom_setup_cmdline() and rb532_gpio_init() static
Date: Mon, 15 Apr 2024 10:33:27 +0200 [thread overview]
Message-ID: <ZhzmV0QHKRaftNx6@alpha.franken.de> (raw)
In-Reply-To: <20240315041043.240833-1-zhangyongzhen@kylinos.cn>
On Fri, Mar 15, 2024 at 12:10:43PM +0800, Yongzhen Zhang wrote:
> early_tlb_init() and rb532_gpio_init() were local to file but not declared
> static, leading to error:
>
> arch/mips/rb532/prom.c:49:13: error: no previous prototype for ‘prom_setup_cmdline’ [-Werror=missing-prototypes]
> 49 | void __init prom_setup_cmdline(void)
> | ^~~~~~~~~~~~~~~~~~
> arch/mips/rb532/gpio.c:200:12: error: no previous prototype for ‘rb532_gpio_init’ [-Werror=missing-prototypes]
> 200 | int __init rb532_gpio_init(void)
> | ^~~~~~~~~~~~~~~
>
> Signed-off-by: Yongzhen Zhang <zhangyongzhen@kylinos.cn>
> ---
> arch/mips/rb532/gpio.c | 2 +-
> arch/mips/rb532/prom.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/mips/rb532/gpio.c b/arch/mips/rb532/gpio.c
> index 29c21b9d42da..ea6ebfea4a67 100644
> --- a/arch/mips/rb532/gpio.c
> +++ b/arch/mips/rb532/gpio.c
> @@ -197,7 +197,7 @@ void rb532_gpio_set_func(unsigned gpio)
> }
> EXPORT_SYMBOL(rb532_gpio_set_func);
>
> -int __init rb532_gpio_init(void)
> +static int __init rb532_gpio_init(void)
> {
> struct resource *r;
>
> diff --git a/arch/mips/rb532/prom.c b/arch/mips/rb532/prom.c
> index b11693715547..b88e89ec5894 100644
> --- a/arch/mips/rb532/prom.c
> +++ b/arch/mips/rb532/prom.c
> @@ -46,7 +46,7 @@ static inline unsigned long tag2ul(char *arg, const char *tag)
> return simple_strtoul(num, 0, 10);
> }
>
> -void __init prom_setup_cmdline(void)
> +static void __init prom_setup_cmdline(void)
> {
> static char cmd_line[COMMAND_LINE_SIZE] __initdata;
> char *cp, *board;
> --
> 2.34.1
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2024-04-15 8:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 4:10 [PATCH] MIPS: RB532: Declare prom_setup_cmdline() and rb532_gpio_init() static Yongzhen Zhang
2024-04-15 8:33 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZhzmV0QHKRaftNx6@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=linux-mips@vger.kernel.org \
--cc=zhangyongzhen@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).