From: Keguang Zhang <keguang.zhang@gmail.com>
To: Conor Dooley <conor@kernel.org>
Cc: Huacai Chen <chenhuacai@kernel.org>,
Vinod Koul <vkoul@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-mips@vger.kernel.org, dmaengine@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 0/2] Add support for Loongson1 DMA
Date: Wed, 20 Mar 2024 10:27:21 +0800 [thread overview]
Message-ID: <CAJhJPsWN24p8VcLeeB8v_JU6KXTVBzWWcE-Aj4Tc2urqx6sYrw@mail.gmail.com> (raw)
In-Reply-To: <20240319-trimester-manhole-3bd092f3343f@spud>
On Wed, Mar 20, 2024 at 1:41 AM Conor Dooley <conor@kernel.org> wrote:
>
> On Tue, Mar 19, 2024 at 10:40:54AM +0800, Huacai Chen wrote:
> > On Tue, Mar 19, 2024 at 10:32 AM Keguang Zhang <keguang.zhang@gmail.com> wrote:
> > >
> > > On Mon, Mar 18, 2024 at 11:42 PM Conor Dooley <conor@kernel.org> wrote:
> > > >
> > > > On Mon, Mar 18, 2024 at 10:26:51PM +0800, Huacai Chen wrote:
> > > > > Hi, Conor,
> > > > >
> > > > > On Mon, Mar 18, 2024 at 7:28 PM Conor Dooley <conor@kernel.org> wrote:
> > > > > >
> > > > > > On Mon, Mar 18, 2024 at 03:31:59PM +0800, Huacai Chen wrote:
> > > > > > > On Mon, Mar 18, 2024 at 10:08 AM Keguang Zhang <keguang.zhang@gmail.com> wrote:
> > > > > > > >
> > > > > > > > Hi Huacai,
> > > > > > > >
> > > > > > > > > Hi, Keguang,
> > > > > > > > >
> > > > > > > > > Sorry for the late reply, there is already a ls2x-apb-dma driver, I'm
> > > > > > > > > not sure but can they share the same code base? If not, can rename
> > > > > > > > > this driver to ls1x-apb-dma for consistency?
> > > > > > > >
> > > > > > > > There are some differences between ls1x DMA and ls2x DMA, such as
> > > > > > > > registers and DMA descriptors.
> > > > > > > > I will rename it to ls1x-apb-dma.
> > > > > > > OK, please also rename the yaml file to keep consistency.
> > > > > >
> > > > > > No, the yaml file needs to match the (one of the) compatible strings.
> > > > > OK, then I think we can also rename the compatible strings, if possible.
> > > >
> > > > If there are no other types of dma controller on this device, I do not
> > > > see why would we add "apb" into the compatible as there is nothing to
> > > > differentiate this controller from.
> > >
> > > That's true. 1A/1B/1C only have one APB DMA.
> > > Should I keep the compatible "ls1b-dma" and "ls1c-dma"?
> > The name "apbdma" comes from the user manual, "exchange data between
> > memory and apb devices", at present there are two drivers using this
> > naming: tegra20-apb-dma.c and ls2x-apb-dma.c.
>
> I think it's unnessesary but I won't stand in your way.
Then I will follow Huacai's suggestion.
Thanks for your review, Conor and Huacai.
--
Best regards,
Keguang Zhang
prev parent reply other threads:[~2024-03-20 2:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-16 11:33 [PATCH v6 0/2] Add support for Loongson1 DMA Keguang Zhang via B4 Relay
2024-03-16 11:33 ` [PATCH v6 1/2] dt-bindings: dma: Add Loongson-1 DMA Keguang Zhang via B4 Relay
2024-03-17 14:40 ` Conor Dooley
2024-03-18 6:18 ` Keguang Zhang
2024-03-18 11:29 ` Conor Dooley
2024-03-19 2:16 ` Keguang Zhang
2024-03-19 8:28 ` Keguang Zhang
2024-03-16 11:33 ` [PATCH v6 2/2] dmaengine: Loongson1: Add Loongson1 dmaengine driver Keguang Zhang via B4 Relay
2024-03-16 14:04 ` [PATCH v6 0/2] Add support for Loongson1 DMA Huacai Chen
2024-03-18 2:07 ` Keguang Zhang
2024-03-18 7:31 ` Huacai Chen
2024-03-18 11:28 ` Conor Dooley
2024-03-18 14:26 ` Huacai Chen
2024-03-18 15:42 ` Conor Dooley
2024-03-19 2:32 ` Keguang Zhang
2024-03-19 2:40 ` Huacai Chen
2024-03-19 17:40 ` Conor Dooley
2024-03-20 2:27 ` Keguang Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJhJPsWN24p8VcLeeB8v_JU6KXTVBzWWcE-Aj4Tc2urqx6sYrw@mail.gmail.com \
--to=keguang.zhang@gmail.com \
--cc=chenhuacai@kernel.org \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).