From: Jiaxun Yang <jiaxun.yang@flygoat.com>
To: Zenghui Yu <yuzenghui@huawei.com>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de, maz@kernel.org, wanghaibin.wang@huawei.com,
Huacai Chen <chenhuacai@kernel.org>
Subject: Re: [PATCH] irqchip/loongson-pch-msi: Fix off-by-one on allocation error path
Date: Sat, 30 Mar 2024 11:38:40 +0000 [thread overview]
Message-ID: <71eda6f7-0455-48ee-82b6-33f9e631f3d0@flygoat.com> (raw)
In-Reply-To: <20240327142334.1098-1-yuzenghui@huawei.com>
在 2024/3/27 14:23, Zenghui Yu 写道:
> When pch_msi_parent_domain_alloc() returns an error, there is an off-by-one
> in the number of IRQs to be freed.
>
> Fix it by passing the number of successfully allocated IRQs, instead of the
> relative index of the last allocated one.
>
> Fixes: 632dcc2c75ef ("irqchip: Add Loongson PCH MSI controller")
> Cc: Huacai Chen <chenhuacai@kernel.org>
> Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>
> Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
Reviewed-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
I copied that piece of code from another driver without thinking.
Good catch!
> ---
> drivers/irqchip/irq-loongson-pch-msi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-loongson-pch-msi.c b/drivers/irqchip/irq-loongson-pch-msi.c
> index 6e1e1f011bb2..dd4d699170f4 100644
> --- a/drivers/irqchip/irq-loongson-pch-msi.c
> +++ b/drivers/irqchip/irq-loongson-pch-msi.c
> @@ -136,7 +136,7 @@ static int pch_msi_middle_domain_alloc(struct irq_domain *domain,
>
> err_hwirq:
> pch_msi_free_hwirq(priv, hwirq, nr_irqs);
> - irq_domain_free_irqs_parent(domain, virq, i - 1);
> + irq_domain_free_irqs_parent(domain, virq, i);
>
> return err;
> }
prev parent reply other threads:[~2024-03-30 11:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 14:23 [PATCH] irqchip/loongson-pch-msi: Fix off-by-one on allocation error path Zenghui Yu
2024-03-30 11:38 ` Jiaxun Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71eda6f7-0455-48ee-82b6-33f9e631f3d0@flygoat.com \
--to=jiaxun.yang@flygoat.com \
--cc=chenhuacai@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
--cc=wanghaibin.wang@huawei.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).