From: Heiner Kallweit <hkallweit1@gmail.com>
To: Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: "linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
linux-sound@vger.kernel.org,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
linux-mips@vger.kernel.org
Subject: [PATCH 0/4] leds: trigger: Improve handling of led_trigger_event() and simplify mute audio trigger
Date: Tue, 13 Feb 2024 08:30:30 +0100 [thread overview]
Message-ID: <30d49088-283c-40f3-b97b-fd5f5174a467@gmail.com> (raw)
If a simple trigger is assigned to a LED, then the LED may be off until
the next led_trigger_event() call. This may be an issue for simple
triggers with rare led_trigger_event() calls, e.g. power supply
charging indicators (drivers/power/supply/power_supply_leds.c).
Therefore persist the brightness value of the last led_trigger_event()
call and use this value if the trigger is assigned to a LED.
This change allows to use simple triggers in more cases.
As a first use case simplify handling of the mute audio trigger.
This series touches few subsystems. I'd propose to handle it via
the LED subsystem.
Heiner Kallweit (4):
leds: trigger: Store brightness set by led_trigger_event()
ALSA: control-led: Integrate mute led trigger
Input: leds: Prepare for removal of config option LEDS_AUDIO_TRIGGER
leds: trigger: audio: Remove this trigger
arch/mips/configs/ci20_defconfig | 1 -
drivers/input/input-leds.c | 8 +---
drivers/leds/led-triggers.c | 6 ++-
drivers/leds/trigger/Kconfig | 7 ---
drivers/leds/trigger/Makefile | 1 -
drivers/leds/trigger/ledtrig-audio.c | 67 ----------------------------
include/linux/leds.h | 29 ++++++------
sound/core/Kconfig | 1 -
sound/core/control_led.c | 20 +++++++--
9 files changed, 37 insertions(+), 103 deletions(-)
delete mode 100644 drivers/leds/trigger/ledtrig-audio.c
--
2.43.1
next reply other threads:[~2024-02-13 7:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 7:30 Heiner Kallweit [this message]
2024-02-13 7:31 ` [PATCH 1/4] leds: trigger: Store brightness set by led_trigger_event() Heiner Kallweit
2024-02-13 7:32 ` [PATCH 2/4] ALSA: control-led: Integrate mute led trigger Heiner Kallweit
2024-02-13 7:33 ` [PATCH 3/4] Input: leds: Prepare for removal of config option LEDS_AUDIO_TRIGGER Heiner Kallweit
2024-02-23 23:23 ` Dmitry Torokhov
2024-02-24 9:31 ` Heiner Kallweit
2024-02-26 17:49 ` Dmitry Torokhov
2024-02-13 7:34 ` [PATCH 4/4] leds: trigger: audio: Remove this trigger Heiner Kallweit
2024-02-15 12:29 ` [PATCH 0/4] leds: trigger: Improve handling of led_trigger_event() and simplify mute audio trigger Takashi Iwai
2024-02-16 12:18 ` Heiner Kallweit
2024-02-23 15:45 ` Lee Jones
2024-02-23 15:47 ` Takashi Iwai
2024-02-23 16:04 ` Lee Jones
2024-02-23 16:05 ` Takashi Iwai
2024-02-23 16:05 ` Lee Jones
2024-02-29 17:26 ` Lee Jones
2024-03-02 15:09 ` Heiner Kallweit
2024-03-05 9:55 ` Lee Jones
2024-03-05 10:26 ` Takashi Iwai
2024-03-05 10:40 ` Lee Jones
2024-03-05 12:08 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30d49088-283c-40f3-b97b-fd5f5174a467@gmail.com \
--to=hkallweit1@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=lee@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).