From: Thorsten Blum <thorsten.blum@toblux.com>
To: John Crispin <john@phrozen.org>,
Sergio Paracuellos <sergio.paracuellos@gmail.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
Thorsten Blum <thorsten.blum@toblux.com>
Subject: [PATCH] MIPS: ralink: Use min() to fix Coccinelle warning
Date: Tue, 9 Apr 2024 17:35:20 +0200 [thread overview]
Message-ID: <20240409153519.291205-2-thorsten.blum@toblux.com> (raw)
Fixes the following Coccinelle/coccicheck warning reported by
minmax.cocci:
WARNING opportunity for min()
Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
---
arch/mips/ralink/timer.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/arch/mips/ralink/timer.c b/arch/mips/ralink/timer.c
index 54094f6e033e..d271ac98312a 100644
--- a/arch/mips/ralink/timer.c
+++ b/arch/mips/ralink/timer.c
@@ -75,11 +75,7 @@ static int rt_timer_request(struct rt_timer *rt)
static int rt_timer_config(struct rt_timer *rt, unsigned long divisor)
{
- if (rt->timer_freq < divisor)
- rt->timer_div = rt->timer_freq;
- else
- rt->timer_div = divisor;
-
+ rt->timer_div = min(rt->timer_freq, divisor);
rt_timer_w32(rt, TIMER_REG_TMR0LOAD, rt->timer_freq / rt->timer_div);
return 0;
--
2.44.0
next reply other threads:[~2024-04-09 15:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 15:35 Thorsten Blum [this message]
2024-04-10 10:43 ` [PATCH] MIPS: ralink: Use min() to fix Coccinelle warning Sergio Paracuellos
2024-04-15 8:42 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240409153519.291205-2-thorsten.blum@toblux.com \
--to=thorsten.blum@toblux.com \
--cc=john@phrozen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=sergio.paracuellos@gmail.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).