From: James Hogan <james.hogan-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
To: Alex Dowad <alexinbeijing-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-metag-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCHv3 16/32] metag: copy_thread(): rename 'arg' argument to 'kthread_arg'
Date: Mon, 16 Mar 2015 14:52:25 +0000 [thread overview]
Message-ID: <5506EE29.50802@imgtec.com> (raw)
In-Reply-To: <1426516727-20692-1-git-send-email-alexinbeijing-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1809 bytes --]
On 16/03/15 14:38, Alex Dowad wrote:
> The 'arg' argument to copy_thread() is only ever used when forking a new
> kernel thread. Hence, rename it to 'kthread_arg' for clarity.
>
> Signed-off-by: Alex Dowad <alexinbeijing-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>
> Fixed problem with whitespace, sending again. AD
>
> arch/metag/kernel/process.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/arch/metag/kernel/process.c b/arch/metag/kernel/process.c
> index 483dff9..dcb4609 100644
> --- a/arch/metag/kernel/process.c
> +++ b/arch/metag/kernel/process.c
> @@ -174,8 +174,11 @@ void show_regs(struct pt_regs *regs)
> show_trace(NULL, (unsigned long *)regs->ctx.AX[0].U0, regs);
> }
>
> +/*
> + * Copy architecture-specific thread state
> + */
> int copy_thread(unsigned long clone_flags, unsigned long usp,
> - unsigned long arg, struct task_struct *tsk)
> + unsigned long kthread_arg, struct task_struct *tsk)
> {
> struct pt_regs *childregs = task_pt_regs(tsk);
> void *kernel_context = ((void *) childregs +
> @@ -204,10 +207,11 @@ int copy_thread(unsigned long clone_flags, unsigned long usp,
> childregs->ctx.AX[0].U0 = (unsigned long) kernel_context;
> - /* Set D1Ar1=arg and D1RtP=usp (fn) */
> + /* Set D1Ar1=kthread_arg and D1RtP=usp (fn) */
FYI this still has a space before the tab, and isn't indented to the
same level as the surrounding code, but I'll just fix that up when I
apply it.
Thanks
James
> childregs->ctx.DX[4].U1 = usp;
> - childregs->ctx.DX[3].U1 = arg;
> + childregs->ctx.DX[3].U1 = kthread_arg;
> tsk->thread.int_depth = 2;
> return 0;
> }
> +
> /*
> * Get a pointer to where the new child's register block should have
> * been pushed.
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-03-16 14:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1426270496-26362-1-git-send-email-alexinbeijing@gmail.com>
2015-03-13 18:14 ` [PATCH 16/32] metag: copy_thread(): rename 'arg' argument to 'kthread_arg' Alex Dowad
2015-03-16 11:39 ` James Hogan
2015-03-16 13:13 ` [PATCHv2 " Alex Dowad
2015-03-16 14:31 ` James Hogan
2015-03-16 14:38 ` Alex Dowad
2015-03-16 14:38 ` [PATCHv3 " Alex Dowad
[not found] ` <1426516727-20692-1-git-send-email-alexinbeijing-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-03-16 14:52 ` James Hogan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5506EE29.50802@imgtec.com \
--to=james.hogan-1axoqhu6uovqt0dzr+alfa@public.gmane.org \
--cc=alexinbeijing-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-metag-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).