From: Ingo Molnar <mingo@kernel.org>
To: Shea Levy <shea@shealevy.com>
Cc: linux-mips@linux-mips.org, linux-sh@vger.kernel.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Linus Walleij <linus.walleij@linaro.org>,
Will Deacon <will.deacon@arm.com>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
"James E.J. Bottomley" <jejb@parisc-linux.org>,
Christoph Hellwig <hch@infradead.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Matt Turner <mattst88@gmail.com>,
Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
uclinux-h8-devel@lists.sourceforge.jp,
Vladimir Murzin <vladimir.murzin@arm.com>,
Marc Zyngier <marc.zyngier@arm.com>,
adi-buildroot-devel@lists.sourceforge.net,
Al Viro <viro@zeniv.linux.org.uk>,
Thomas Gleixner <tglx@linutronix.de>,
Richard Henderson <rth@twiddle.net>,
linux-cris-kernel@axis.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kerne
Subject: Re: [PATCH] Extract initrd free logic from arch-specific code.
Date: Fri, 30 Mar 2018 13:15:17 +0200 [thread overview]
Message-ID: <20180330111517.rrx6gs2skkgk336j@gmail.com> (raw)
In-Reply-To: <20180328152714.6103-1-shea@shealevy.com>
* Shea Levy <shea@shealevy.com> wrote:
> Now only those architectures that have custom initrd free requirements
> need to define free_initrd_mem.
>
> Signed-off-by: Shea Levy <shea@shealevy.com>
Please put the Kconfig symbol name this patch introduces both into the title, so
that people know what to grep for.
> ---
> arch/alpha/mm/init.c | 8 --------
> arch/arc/mm/init.c | 7 -------
> arch/arm/Kconfig | 1 +
> arch/arm64/Kconfig | 1 +
> arch/blackfin/Kconfig | 1 +
> arch/c6x/mm/init.c | 7 -------
> arch/cris/Kconfig | 1 +
> arch/frv/mm/init.c | 11 -----------
> arch/h8300/mm/init.c | 7 -------
> arch/hexagon/Kconfig | 1 +
> arch/ia64/Kconfig | 1 +
> arch/m32r/Kconfig | 1 +
> arch/m32r/mm/init.c | 11 -----------
> arch/m68k/mm/init.c | 7 -------
> arch/metag/Kconfig | 1 +
> arch/microblaze/mm/init.c | 7 -------
> arch/mips/Kconfig | 1 +
> arch/mn10300/Kconfig | 1 +
> arch/nios2/mm/init.c | 7 -------
> arch/openrisc/mm/init.c | 7 -------
> arch/parisc/mm/init.c | 7 -------
> arch/powerpc/mm/mem.c | 7 -------
> arch/riscv/mm/init.c | 6 ------
> arch/s390/Kconfig | 1 +
> arch/score/Kconfig | 1 +
> arch/sh/mm/init.c | 7 -------
> arch/sparc/Kconfig | 1 +
> arch/tile/Kconfig | 1 +
> arch/um/kernel/mem.c | 7 -------
> arch/unicore32/Kconfig | 1 +
> arch/x86/Kconfig | 1 +
> arch/xtensa/Kconfig | 1 +
> init/initramfs.c | 7 +++++++
> usr/Kconfig | 4 ++++
> 34 files changed, 28 insertions(+), 113 deletions(-)
Please also put it into Documentation/features/.
> diff --git a/usr/Kconfig b/usr/Kconfig
> index 43658b8a975e..7a94f6df39bf 100644
> --- a/usr/Kconfig
> +++ b/usr/Kconfig
> @@ -233,3 +233,7 @@ config INITRAMFS_COMPRESSION
> default ".lzma" if RD_LZMA
> default ".bz2" if RD_BZIP2
> default ""
> +
> +config HAVE_ARCH_FREE_INITRD_MEM
> + bool
> + default n
Help text would be nice, to tell arch maintainers what the purpose of this switch
is.
Also, a nit, I think this should be named "ARCH_HAS_FREE_INITRD_MEM", which is the
dominant pattern:
triton:~/tip> git grep 'select.*ARCH' arch/x86/Kconfig* | cut -f2 | cut -d_ -f1-2 | sort | uniq -c | sort -n
...
2 select ARCH_USES
2 select ARCH_WANTS
3 select ARCH_MIGHT
3 select ARCH_WANT
4 select ARCH_SUPPORTS
4 select ARCH_USE
16 select HAVE_ARCH
23 select ARCH_HAS
It also reads nicely in English:
"arch has free_initrd_mem()"
While the other makes little sense:
"have arch free_initrd_mem()"
?
Thanks,
Ingo
next prev parent reply other threads:[~2018-03-30 11:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180325221853.10839-1-shea@shealevy.com>
2018-03-28 15:26 ` [PATCH] Extract initrd free logic from arch-specific code Shea Levy
2018-03-28 15:58 ` Rob Landley
2018-03-28 16:04 ` Shea Levy
2018-03-28 16:48 ` Russell King - ARM Linux
2018-03-28 19:04 ` Rob Landley
2018-03-28 22:14 ` Russell King - ARM Linux
2018-03-28 22:37 ` Oliver
2018-03-29 0:23 ` Nicholas Piggin
2018-03-29 15:27 ` Russell King - ARM Linux
2018-03-29 15:43 ` Geert Uytterhoeven
2018-03-29 15:58 ` Russell King - ARM Linux
2018-03-29 16:53 ` Marc Zyngier
2018-03-29 17:32 ` Russell King - ARM Linux
2018-03-29 17:53 ` Marc Zyngier
2018-03-29 17:43 ` Rob Landley
2018-03-29 16:39 ` Rob Landley
2018-03-29 17:31 ` Russell King - ARM Linux
2018-03-28 16:55 ` Kees Cook
2018-03-29 1:12 ` Wei Yang
2018-03-30 1:43 ` kbuild test robot
2018-03-30 3:16 ` kbuild test robot
2018-03-30 11:15 ` Ingo Molnar [this message]
2018-04-01 15:05 ` Shea Levy
2018-04-02 5:59 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180330111517.rrx6gs2skkgk336j@gmail.com \
--to=mingo@kernel.org \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=adi-buildroot-devel@lists.sourceforge.net \
--cc=benh@kernel.crashing.org \
--cc=catalin.marinas@arm.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=jejb@parisc-linux.org \
--cc=linus.walleij@linaro.org \
--cc=linux-cris-kernel@axis.com \
--cc=linux-kernel@vger.kerne \
--cc=linux-mips@linux-mips.org \
--cc=linux-sh@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mattst88@gmail.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=rth@twiddle.net \
--cc=shea@shealevy.com \
--cc=tglx@linutronix.de \
--cc=uclinux-h8-devel@lists.sourceforge.jp \
--cc=viro@zeniv.linux.org.uk \
--cc=vladimir.murzin@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).