From: James Hogan <james.hogan-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
To: Michal Hocko <mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-metag-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] metag/pgtable: Fix undeclared vm_area_struct warning
Date: Thu, 11 May 2017 09:14:18 +0100 [thread overview]
Message-ID: <20170511081417.GO1088@jhogan-linux.le.imgtec.org> (raw)
In-Reply-To: <20170511073915.GC26782-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1167 bytes --]
Hi Michal,
On Thu, May 11, 2017 at 09:39:15AM +0200, Michal Hocko wrote:
> On Wed 10-05-17 16:36:20, James Hogan wrote:
> > Since commit 1f5307b1e094 ("mm, vmalloc: properly track vmalloc users"),
> > linux/vmalloc.h includes asm/pgtable.h prior to declaring struct
> > vm_area_struct, resulting in warnings such as the following on metag:
> >
> > In file included from ./include/linux/vmalloc.h:10,
> > from lib/ioremap.c:9:
> > ./arch/metag/include/asm/pgtable.h:221: warning: ‘struct vm_area_struct’ declared inside parameter list
> > ./arch/metag/include/asm/pgtable.h:221: warning: its scope is only this definition or declaration, which is probably not what you want
> >
> > Metag's asm/pgtable.h doesn't actually need the definition of struct
> > vm_area_struct, so just declare struct vm_area_struct in the header
> > rather than including linux/mm_types.h.
>
> This will be fixed in a different way [1]. It just waits for Andrew to
> send the patch to Linus.
>
> [1] http://lkml.kernel.org/r/20170509153702.GR6481-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org
Okay cool. I'll drop this patch then.
Thanks
James
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-05-11 8:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-10 15:36 [PATCH] metag/pgtable: Fix undeclared vm_area_struct warning James Hogan
[not found] ` <20170510153620.28133-1-james.hogan-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
2017-05-11 7:39 ` Michal Hocko
[not found] ` <20170511073915.GC26782-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2017-05-11 8:14 ` James Hogan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170511081417.GO1088@jhogan-linux.le.imgtec.org \
--to=james.hogan-1axoqhu6uovqt0dzr+alfa@public.gmane.org \
--cc=linux-metag-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).