From: Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
To: James Hogan <james.hogan-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
Cc: Al Viro <viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org>,
linux-metag-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/2] metag/uaccess: Fix access_ok()
Date: Wed, 3 May 2017 07:36:46 +1000 [thread overview]
Message-ID: <20170503073632.00781d6a@canb.auug.org.au> (raw)
In-Reply-To: <20170502212605.GO1105-4bYivNCBEGTR3KXKvIWQxtm+Uo4AYnCiHZ5vskTnxNA@public.gmane.org>
Hi James,
On Tue, 2 May 2017 22:26:05 +0100 James Hogan <james.hogan-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org> wrote:
>
> > diff --git a/arch/metag/include/asm/uaccess.h b/arch/metag/include/asm/uaccess.h
> > index 469a2f1393d3..1e5f26d2dce8 100644
> > --- a/arch/metag/include/asm/uaccess.h
> > +++ b/arch/metag/include/asm/uaccess.h
> > @@ -28,24 +28,32 @@
> >
> > #define segment_eq(a, b) ((a).seg == (b).seg)
> >
> > -#define __kernel_ok (segment_eq(get_fs(), KERNEL_DS))
>
> FYI this patch, commit 8a8b56638bca ("metag/uaccess: Fix access_ok()"),
> just pushed to metag/for-next, will conflict with Al's commit
> db68ce10c4f0 ("new helper: uaccess_kernel()") from his vfs/for-next
> branch.
>
> This change should supersede Al's metag change, i.e. __kernel_ok should
> be removed from this file.
Thanks for letting me know.
--
Cheers,
Stephen Rothwell
next prev parent reply other threads:[~2017-05-02 21:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-02 21:11 [PATCH 0/2] metag/uaccess: Some more user access fixes James Hogan
[not found] ` <cover.e98ed86557d7dd12941799c9c2d31dd7d3bda36d.1493759289.git-series.james.hogan-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
2017-05-02 21:11 ` [PATCH 1/2] metag/uaccess: Fix access_ok() James Hogan
[not found] ` <8a8b56638bcac4e64cccc88bf95a0f9f4b19a2fb.1493759289.git-series.james.hogan-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
2017-05-02 21:26 ` James Hogan
[not found] ` <20170502212605.GO1105-4bYivNCBEGTR3KXKvIWQxtm+Uo4AYnCiHZ5vskTnxNA@public.gmane.org>
2017-05-02 21:36 ` Stephen Rothwell [this message]
2017-05-02 21:11 ` [PATCH 2/2] metag/uaccess: Check access_ok in strncpy_from_user James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170503073632.00781d6a@canb.auug.org.au \
--to=sfr-3fnu+uhb4dndw9hx6icosa@public.gmane.org \
--cc=james.hogan-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org \
--cc=linux-metag-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).