From: James Hogan <james.hogan-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
To: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-metag-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] metag: Remove duplicate KERN_<LEVEL> prefix
Date: Fri, 15 Jul 2016 10:13:49 +0100 [thread overview]
Message-ID: <20160715091349.GL26799@jhogan-linux.le.imgtec.org> (raw)
In-Reply-To: <a2456707b8e22858529054519f8f60122d96e55d.1468516192.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1171 bytes --]
Hi Joe,
On Thu, Jul 14, 2016 at 10:10:13AM -0700, Joe Perches wrote:
> Use a bare printk to avoid a duplicate KERN_<LEVEL> in logging output.
>
> Signed-off-by: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
Thanks, applied for 4.8.
This appears to have been introduced accidentally while I was checkpatch
cleaning ready for submitting arch/metag upstream.
Cheers
James
> ---
> arch/metag/mm/fault.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/metag/mm/fault.c b/arch/metag/mm/fault.c
> index 372783a..c765b36 100644
> --- a/arch/metag/mm/fault.c
> +++ b/arch/metag/mm/fault.c
> @@ -187,7 +187,7 @@ bad_area_nosemaphore:
>
> if (show_unhandled_signals && unhandled_signal(tsk, SIGSEGV) &&
> printk_ratelimit()) {
> - pr_info("%s%s[%d]: segfault at %lx pc %08x sp %08x write %d trap %#x (%s)",
> + printk("%s%s[%d]: segfault at %lx pc %08x sp %08x write %d trap %#x (%s)",
> task_pid_nr(tsk) > 1 ? KERN_INFO : KERN_EMERG,
> tsk->comm, task_pid_nr(tsk), address,
> regs->ctx.CurrPC, regs->ctx.AX[0].U0,
> --
> 2.8.0.rc4.16.g56331f8
>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-07-15 9:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 17:10 [PATCH] metag: Remove duplicate KERN_<LEVEL> prefix Joe Perches
[not found] ` <a2456707b8e22858529054519f8f60122d96e55d.1468516192.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2016-07-15 9:13 ` James Hogan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160715091349.GL26799@jhogan-linux.le.imgtec.org \
--to=james.hogan-1axoqhu6uovqt0dzr+alfa@public.gmane.org \
--cc=joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-metag-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).