From: "Michael S. Tsirkin" <mst@redhat.com>
To: Joe Perches <joe@perches.com>
Cc: linux-mips@linux-mips.org, linux-ia64@vger.kernel.org,
linux-sh@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
virtualization@lists.linux-foundation.org,
"H. Peter Anvin" <hpa@zytor.com>,
sparclinux@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
linux-arch@vger.kernel.org, linux-s390@vger.kernel.org,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Arnd Bergmann <arnd@arndb.de>,
x86@kernel.org, Tony Lindgren <tony@atomide.com>,
xen-devel@lists.xenproject.org, Ingo Molnar <mingo@elte.hu>,
linux-xtensa@linux-xtensa.org,
user-mode-linux-devel@lists.sourceforge.net,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Andrey Konovalov <andreyknvl@google.com>,
adi-buildroot-devel@lists.sourceforge.net,
"Cc : Andy Whitcroft" <apw@canonical.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-metag@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Andrew
Subject: Re: [PATCH 1/3] checkpatch.pl: add missing memory barriers
Date: Sun, 10 Jan 2016 13:42:28 +0200 [thread overview]
Message-ID: <20160110134133-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <1451945750.4334.111.camel@perches.com>
On Mon, Jan 04, 2016 at 02:15:50PM -0800, Joe Perches wrote:
> On Mon, 2016-01-04 at 22:45 +0200, Michael S. Tsirkin wrote:
> > On Mon, Jan 04, 2016 at 08:07:40AM -0800, Joe Perches wrote:
> > > On Mon, 2016-01-04 at 13:36 +0200, Michael S. Tsirkin wrote:
> > > > SMP-only barriers were missing in checkpatch.pl
> > > >
> > > > Refactor code slightly to make adding more variants easier.
> > > >
> > > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > > > ---
> > > > scripts/checkpatch.pl | 9 ++++++++-
> > > > 1 file changed, 8 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > > > index 2b3c228..0245bbe 100755
> > > > --- a/scripts/checkpatch.pl
> > > > +++ b/scripts/checkpatch.pl
> > > > @@ -5116,7 +5116,14 @@ sub process {
> > > > }
> > > > }
> > > > # check for memory barriers without a comment.
> > > > - if ($line =~ /\b(mb|rmb|wmb|read_barrier_depends|smp_mb|smp_rmb|smp_wmb|smp_read_barrier_depends)\(/) {
> > > > +
> > > > + my @barriers = ('mb', 'rmb', 'wmb', 'read_barrier_depends');
> > > > + my @smp_barriers = ('smp_store_release', 'smp_load_acquire', 'smp_store_mb');
> > > > +
> > > > + @smp_barriers = (@smp_barriers, map {"smp_" . $_} @barriers);
> > >
> > > I think using map, which so far checkpatch doesn't use,
> > > makes smp_barriers harder to understand and it'd be
> > > better to enumerate them.
> >
> > Okay - I'll rewrite using foreach.
> >
>
> I think using the qr form (like 'our $Attribute' and
> a bunch of others) is the general style that should
> be used for checkpatch.
Thanks - that's what I did in the new version (included in
v3 of the arch cleanup patchset now).
next prev parent reply other threads:[~2016-01-10 11:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-04 11:36 [PATCH 0/3] checkpatch: handling of memory barriers Michael S. Tsirkin
2016-01-04 11:36 ` [PATCH 1/3] checkpatch.pl: add missing " Michael S. Tsirkin
2016-01-04 16:07 ` Joe Perches
2016-01-04 16:11 ` Russell King - ARM Linux
2016-01-04 16:15 ` Joe Perches
[not found] ` <1451923660.4334.83.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2016-01-04 20:45 ` Michael S. Tsirkin
[not found] ` <20160104224415-mutt-send-email-mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-01-04 22:15 ` Joe Perches
2016-01-10 11:42 ` Michael S. Tsirkin [this message]
2016-01-04 11:37 ` [PATCH 2/3] checkpatch: check for __smp outside barrier.h Michael S. Tsirkin
2016-01-04 11:37 ` [PATCH 3/3] checkpatch: add virt barriers Michael S. Tsirkin
2016-01-04 16:47 ` Joe Perches
[not found] ` <1451926073.4334.90.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2016-01-04 21:07 ` Michael S. Tsirkin
[not found] ` <20160104230528-mutt-send-email-mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-01-04 22:11 ` Joe Perches
2016-01-08 10:14 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160110134133-mutt-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=adi-buildroot-devel@lists.sourceforge.net \
--cc=andreyknvl@google.com \
--cc=apw@canonical.com \
--cc=arnd@arndb.de \
--cc=hpa@zytor.com \
--cc=joe@perches.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-metag@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=linux@arm.linux.org.uk \
--cc=mingo@elte.hu \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=sparclinux@vger.kernel.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).