From: "CK Hu (胡俊光)" <ck.hu@mediatek.com>
To: "daniel@ffwll.ch" <daniel@ffwll.ch>,
"airlied@gmail.com" <airlied@gmail.com>,
"u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>
Cc: "linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"chunkuang.hu@kernel.org" <chunkuang.hu@kernel.org>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH 2/4] drm/mediatek: Convert to platform remove callback returning void
Date: Thu, 16 May 2024 02:54:40 +0000 [thread overview]
Message-ID: <a11b85d6b92a9c7269fe33200711f507735fc07a.camel@mediatek.com> (raw)
In-Reply-To: <4a64dfbfbcfdf9b7cd46bc8026223e69a4b453b4.1712681770.git.u.kleine-koenig@pengutronix.de>
Hi, Uwe:
On Tue, 2024-04-09 at 19:02 +0200, Uwe Kleine-König wrote:
>
>
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
Reviewed-by: CK Hu <ck.hu@mediatek.com>
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/gpu/drm/mediatek/mtk_padding.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_padding.c b/drivers/gpu/drm/mediatek/mtk_padding.c
> index 0d6451c149b6..9f92b720aaae 100644
> --- a/drivers/gpu/drm/mediatek/mtk_padding.c
> +++ b/drivers/gpu/drm/mediatek/mtk_padding.c
> @@ -137,10 +137,9 @@ static int mtk_padding_probe(struct platform_device *pdev)
> return 0;
> }
>
> -static int mtk_padding_remove(struct platform_device *pdev)
> +static void mtk_padding_remove(struct platform_device *pdev)
> {
> component_del(&pdev->dev, &mtk_padding_component_ops);
> -return 0;
> }
>
> static const struct of_device_id mtk_padding_driver_dt_match[] = {
> @@ -151,7 +150,7 @@ MODULE_DEVICE_TABLE(of, mtk_padding_driver_dt_match);
>
> struct platform_driver mtk_padding_driver = {
> .probe= mtk_padding_probe,
> -.remove= mtk_padding_remove,
> +.remove_new= mtk_padding_remove,
> .driver= {
> .name= "mediatek-disp-padding",
> .owner= THIS_MODULE,
> --
> 2.43.0
>
next prev parent reply other threads:[~2024-05-16 2:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 17:02 [PATCH 0/4] gpu: Convert to platform remove callback returning void Uwe Kleine-König
2024-04-09 17:02 ` [PATCH 2/4] drm/mediatek: " Uwe Kleine-König
2024-05-16 2:54 ` CK Hu (胡俊光) [this message]
2024-05-16 10:12 ` AngeloGioacchino Del Regno
2024-04-09 17:10 ` [PATCH 0/4] gpu: " Uwe Kleine-König
2024-04-09 18:59 ` Thomas Zimmermann
2024-04-19 7:20 ` Uwe Kleine-König
2024-04-19 11:28 ` Thierry Reding
2024-04-23 8:31 ` Matt Coster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a11b85d6b92a9c7269fe33200711f507735fc07a.camel@mediatek.com \
--to=ck.hu@mediatek.com \
--cc=airlied@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).