From: "Olivia Wen (温倩苓)" <Olivia.Wen@mediatek.com>
To: "robh@kernel.org" <robh@kernel.org>,
"mathieu.poirier@linaro.org" <mathieu.poirier@linaro.org>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>,
"andersson@kernel.org" <andersson@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-remoteproc@vger.kernel.org"
<linux-remoteproc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Jason-ch Chen (陳建豪)" <Jason-ch.Chen@mediatek.com>,
"Yaya Chang (張雅清)" <Yaya.Chang@mediatek.com>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
"Teddy Chen (陳乾元)" <Teddy.Chen@mediatek.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"TingHan Shen (沈廷翰)" <TingHan.Shen@mediatek.com>
Subject: Re: [PATCH 1/2] dt-bindings: remoteproc: mediatek: Support MT8188 dual-core SCP
Date: Wed, 24 Apr 2024 00:58:06 +0000 [thread overview]
Message-ID: <66b3c11d7de51f4f2a3eeaf23bf6004c4cd01005.camel@mediatek.com> (raw)
In-Reply-To: <6e8e553b-8c5f-404a-a396-17d8b3440d93@collabora.com>
Hi AngeloGioacchino,
On Thu, 2024-04-11 at 09:39 +0200, AngeloGioacchino Del Regno wrote:
> Il 11/04/24 09:34, AngeloGioacchino Del Regno ha scritto:
> > Il 11/04/24 05:37, olivia.wen ha scritto:
> > > Under different applications, the MT8188 SCP can be used as
> > > single-core
> > > or dual-core.
> > >
> > > Signed-off-by: olivia.wen <olivia.wen@mediatek.com>
> > > ---
> > > Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 3
> > > ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> > > b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> > > index 507f98f..7e7b567 100644
> > > --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> > > +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> > > @@ -22,7 +22,7 @@ properties:
> > > - mediatek,mt8192-scp
> > > - mediatek,mt8195-scp
> > > - mediatek,mt8195-scp-dual
> > > -
> >
> > Don't remove the blank line, it's there for readability.
> >
> > > + - mediatek,mt8188-scp-dual
>
> Ah, sorry, one more comment. Please, keep the entries ordered by
> name.
> 8188 goes before 8195.
>
> >
> > After addressing that comment,
> >
> > Reviewed-by: AngeloGioacchino Del Regno <
> > angelogioacchino.delregno@collabora.com>
> >
> > > reg:
> > > description:
> > > Should contain the address ranges for memory regions
> > > SRAM, CFG, and,
> > > @@ -195,6 +195,7 @@ allOf:
> > > compatible:
> > > enum:
> > > - mediatek,mt8195-scp-dual
> > > + - mediatek,mt8188-scp-dual
>
> same here.
>
> > > then:
> > > properties:
> > > reg:
> >
> >
>
Thanks for the reviews.
It will be corrected in the next version.
Best regards,
Olivia
next prev parent reply other threads:[~2024-04-24 1:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 3:37 [PATCH 0/2] Support MT8188 SCP core 1 olivia.wen
2024-04-11 3:37 ` [PATCH 1/2] dt-bindings: remoteproc: mediatek: Support MT8188 dual-core SCP olivia.wen
2024-04-11 6:06 ` Krzysztof Kozlowski
2024-04-12 11:00 ` Olivia Wen (温倩苓)
2024-04-11 7:34 ` AngeloGioacchino Del Regno
2024-04-11 7:39 ` AngeloGioacchino Del Regno
2024-04-12 10:18 ` Olivia Wen (温倩苓)
2024-04-12 11:01 ` Olivia Wen (温倩苓)
2024-04-24 0:58 ` Olivia Wen (温倩苓) [this message]
2024-04-11 3:37 ` [PATCH 2/2] remoteproc: mediatek: Support MT8188 SCP core 1 olivia.wen
2024-04-11 6:07 ` Krzysztof Kozlowski
2024-04-12 11:06 ` Olivia Wen (温倩苓)
2024-04-11 7:33 ` AngeloGioacchino Del Regno
2024-04-12 10:49 ` Olivia Wen (温倩苓)
2024-04-12 11:26 ` Olivia Wen (温倩苓)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66b3c11d7de51f4f2a3eeaf23bf6004c4cd01005.camel@mediatek.com \
--to=olivia.wen@mediatek.com \
--cc=Jason-ch.Chen@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=Teddy.Chen@mediatek.com \
--cc=TingHan.Shen@mediatek.com \
--cc=Yaya.Chang@mediatek.com \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).