From: "LIANKUN YANG (杨连坤)" <Liankun.Yang@mediatek.com>
To: "Mac Shen (沈俊)" <Mac.Shen@mediatek.com>,
"chunkuang.hu@kernel.org" <chunkuang.hu@kernel.org>,
"Jitao Shi (石记涛)" <jitao.shi@mediatek.com>,
"daniel@ffwll.ch" <daniel@ffwll.ch>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"airlied@gmail.com" <airlied@gmail.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>
Cc: "dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/1] Fix get efuse issue for MT8188 DPTX
Date: Mon, 13 May 2024 03:49:26 +0000 [thread overview]
Message-ID: <2f831b6ec2123001134933c2d75d33602696e528.camel@mediatek.com> (raw)
In-Reply-To: <f72b241f-11ab-4165-af51-14413d4e9f7a@collabora.com>
On Fri, 2024-05-10 at 12:09 +0200, AngeloGioacchino Del Regno wrote:
> Il 10/05/24 08:16, Liankun Yang ha scritto:
> > Fix get efuse issue for MT8188 DPTX.
> >
> > Signed-off-by: Liankun Yang <liankun.yang@mediatek.com>
>
> I may agree with this commit, but:
> 1. The commit title is incorrect - I don't see "drm/mediatek:" -
> please look at
> the history to find out the right titles for your commits; and
> 2. The commit description isn't describing anything, you're just
> repeating the
> title: please add a description. What was wrong? What did you fix
> precisely?
> 3. There's no Fixes tag. Please add the relevant one.
>
> Regards,
> Angelo
>
> > ---
> > drivers/gpu/drm/mediatek/mtk_dp.c | 85
> > ++++++++++++++++++++++++++++++-
> > 1 file changed, 84 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c
> > b/drivers/gpu/drm/mediatek/mtk_dp.c
> > index 2136a596efa1..32b36b63a4e1 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_dp.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_dp.c
> > @@ -145,6 +145,89 @@ struct mtk_dp_data {
> > u16 audio_m_div2_bit;
> > };
> >
> > +static const struct mtk_dp_efuse_fmt
> > mt8188_dp_efuse_fmt[MTK_DP_CAL_MAX] = {
> > + [MTK_DP_CAL_GLB_BIAS_TRIM] = {
> > + .idx = 0,
> > + .shift = 10,
> > + .mask = 0x1f,
> > + .min_val = 1,
> > + .max_val = 0x1e,
> > + .default_val = 0xf,
> > + },
> > + [MTK_DP_CAL_CLKTX_IMPSE] = {
> > + .idx = 0,
> > + .shift = 15,
> > + .mask = 0xf,
> > + .min_val = 1,
> > + .max_val = 0xe,
> > + .default_val = 0x8,
> > + },
> > + [MTK_DP_CAL_LN_TX_IMPSEL_PMOS_0] = {
> > + .idx = 1,
> > + .shift = 0,
> > + .mask = 0xf,
> > + .min_val = 1,
> > + .max_val = 0xe,
> > + .default_val = 0x8,
> > + },
> > + [MTK_DP_CAL_LN_TX_IMPSEL_PMOS_1] = {
> > + .idx = 1,
> > + .shift = 8,
> > + .mask = 0xf,
> > + .min_val = 1,
> > + .max_val = 0xe,
> > + .default_val = 0x8,
> > + },
> > + [MTK_DP_CAL_LN_TX_IMPSEL_PMOS_2] = {
> > + .idx = 1,
> > + .shift = 16,
> > + .mask = 0xf,
> > + .min_val = 1,
> > + .max_val = 0xe,
> > + .default_val = 0x8,
> > + },
> > + [MTK_DP_CAL_LN_TX_IMPSEL_PMOS_3] = {
> > + .idx = 1,
> > + .shift = 24,
> > + .mask = 0xf,
> > + .min_val = 1,
> > + .max_val = 0xe,
> > + .default_val = 0x8,
> > + },
> > + [MTK_DP_CAL_LN_TX_IMPSEL_NMOS_0] = {
> > + .idx = 1,
> > + .shift = 4,
> > + .mask = 0xf,
> > + .min_val = 1,
> > + .max_val = 0xe,
> > + .default_val = 0x8,
> > + },
> > + [MTK_DP_CAL_LN_TX_IMPSEL_NMOS_1] = {
> > + .idx = 1,
> > + .shift = 12,
> > + .mask = 0xf,
> > + .min_val = 1,
> > + .max_val = 0xe,
> > + .default_val = 0x8,
> > + },
> > + [MTK_DP_CAL_LN_TX_IMPSEL_NMOS_2] = {
> > + .idx = 1,
> > + .shift = 20,
> > + .mask = 0xf,
> > + .min_val = 1,
> > + .max_val = 0xe,
> > + .default_val = 0x8,
> > + },
> > + [MTK_DP_CAL_LN_TX_IMPSEL_NMOS_3] = {
> > + .idx = 1,
> > + .shift = 28,
> > + .mask = 0xf,
> > + .min_val = 1,
> > + .max_val = 0xe,
> > + .default_val = 0x8,
> > + },
> > +};
> > +
> > static const struct mtk_dp_efuse_fmt
> > mt8195_edp_efuse_fmt[MTK_DP_CAL_MAX] = {
> > [MTK_DP_CAL_GLB_BIAS_TRIM] = {
> > .idx = 3,
> > @@ -2758,7 +2841,7 @@ static SIMPLE_DEV_PM_OPS(mtk_dp_pm_ops,
> > mtk_dp_suspend, mtk_dp_resume);
> > static const struct mtk_dp_data mt8188_dp_data = {
> > .bridge_type = DRM_MODE_CONNECTOR_DisplayPort,
> > .smc_cmd = MTK_DP_SIP_ATF_VIDEO_UNMUTE,
> > - .efuse_fmt = mt8195_dp_efuse_fmt,
> > + .efuse_fmt = mt8188_dp_efuse_fmt,
> > .audio_supported = true,
> > .audio_pkt_in_hblank_area = true,
> > .audio_m_div2_bit =
> > MT8188_AUDIO_M_CODE_MULT_DIV_SEL_DP_ENC0_P0_DIV_2,
>
> Sorry.I will send the second edition,and fixing the commit title and
> commit description.
prev parent reply other threads:[~2024-05-13 3:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 6:16 [PATCH v1 1/1] Fix get efuse issue for MT8188 DPTX Liankun Yang
2024-05-10 10:09 ` AngeloGioacchino Del Regno
2024-05-13 3:49 ` LIANKUN YANG (杨连坤) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f831b6ec2123001134933c2d75d33602696e528.camel@mediatek.com \
--to=liankun.yang@mediatek.com \
--cc=Mac.Shen@mediatek.com \
--cc=airlied@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jitao.shi@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).