From: Nicolas Dufresne <nicolas@ndufresne.ca>
To: Benjamin Gaignard <benjamin.gaignard@collabora.com>,
ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de,
mchehab@kernel.org, heiko@sntech.de
Cc: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCH] media: verisilicon: AV1: Be more fexible on postproc capabilities
Date: Thu, 04 Apr 2024 13:59:33 -0400 [thread overview]
Message-ID: <e4d01c27aa976c44e0b7122e39111be062a4deb4.camel@ndufresne.ca> (raw)
In-Reply-To: <20240328093439.18712-1-benjamin.gaignard@collabora.com>
Hi,
Le jeudi 28 mars 2024 à 10:34 +0100, Benjamin Gaignard a écrit :
> RK3588 post-processor block is able to convert 10 bits streams
> into 8 bits pixels format.
Does it come with any HDR to SDR capabilities ? cause stripping off 2 bits means
that tone mapping will cause a lot of banding as it won't have the expected
precision. I'm simply trying to make up the big portrait so we don't just offer
yet another foot gun. But perhaps its fine to offer this, its just that we don't
have a mechanism to report which pixel format in the selection will cause data
lost.
Nicolas
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
> Fixes: 003afda97c65 ("media: verisilicon: Enable AV1 decoder on rk3588")
> ---
> drivers/media/platform/verisilicon/rockchip_vpu_hw.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/platform/verisilicon/rockchip_vpu_hw.c b/drivers/media/platform/verisilicon/rockchip_vpu_hw.c
> index f97527670783..964122e7c355 100644
> --- a/drivers/media/platform/verisilicon/rockchip_vpu_hw.c
> +++ b/drivers/media/platform/verisilicon/rockchip_vpu_hw.c
> @@ -82,7 +82,6 @@ static const struct hantro_fmt rockchip_vpu981_postproc_fmts[] = {
> {
> .fourcc = V4L2_PIX_FMT_NV12,
> .codec_mode = HANTRO_MODE_NONE,
> - .match_depth = true,
> .postprocessed = true,
> .frmsize = {
> .min_width = ROCKCHIP_VPU981_MIN_SIZE,
next prev parent reply other threads:[~2024-04-04 17:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 9:34 [PATCH] media: verisilicon: AV1: Be more fexible on postproc capabilities Benjamin Gaignard
2024-03-28 9:34 ` [PATCH] media: verisilicon: Fix auxiliary buffers allocation size Benjamin Gaignard
2024-04-04 18:00 ` Nicolas Dufresne
2024-04-05 8:13 ` Benjamin Gaignard
2024-05-06 14:38 ` Benjamin Gaignard
2024-05-13 14:52 ` Nicolas Dufresne
2024-04-04 17:59 ` Nicolas Dufresne [this message]
2024-04-05 8:17 ` [PATCH] media: verisilicon: AV1: Be more fexible on postproc capabilities Benjamin Gaignard
2024-05-06 14:38 ` Benjamin Gaignard
2024-05-13 14:55 ` Nicolas Dufresne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4d01c27aa976c44e0b7122e39111be062a4deb4.camel@ndufresne.ca \
--to=nicolas@ndufresne.ca \
--cc=benjamin.gaignard@collabora.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=heiko@sntech.de \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).