From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Marc Gonzalez <mgonzalez@freebox.fr>,
Vikash Garodia <quic_vgarodia@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Jeffrey Hugo <quic_jhugo@quicinc.com>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Stanimir Varbanov <stanimir.k.varbanov@gmail.com>
Cc: MSM <linux-arm-msm@vger.kernel.org>,
linux-media <linux-media@vger.kernel.org>,
DT <devicetree@vger.kernel.org>,
Pierre-Hugues Husson <phhusson@freebox.fr>,
Arnaud Vrac <avrac@freebox.fr>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH v3 3/3] media: venus: add msm8998 support
Date: Mon, 6 May 2024 16:57:01 +0100 [thread overview]
Message-ID: <ddd78134-6f04-4ef6-a3fa-4a2932d81165@linaro.org> (raw)
In-Reply-To: <4349e7ea-380d-4c91-83be-d74983e2cdb0@freebox.fr>
On 06/05/2024 15:51, Marc Gonzalez wrote:
> On 06/05/2024 16:43, Vikash Garodia wrote:
>
>> On 5/6/2024 7:17 PM, Marc Gonzalez wrote:
>>
>>> From: Pierre-Hugues Husson <phhusson@freebox.fr>
>>>
>>> Add the missing bits for msm8998 support.
>>>
>>> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>>> Signed-off-by: Pierre-Hugues Husson <phhusson@freebox.fr>
>>> Signed-off-by: Marc Gonzalez <mgonzalez@freebox.fr>
>>> ---
>>> drivers/media/platform/qcom/venus/core.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
>>> 1 file changed, 48 insertions(+)
>>>
>>> diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
>>> index ce206b7097541..064120127cb86 100644
>>> --- a/drivers/media/platform/qcom/venus/core.c
>>> +++ b/drivers/media/platform/qcom/venus/core.c
>>> @@ -554,6 +554,9 @@ static const struct venus_resources msm8916_res = {
>>> .fwname = "qcom/venus-1.8/venus.mbn",
>>> };
>>>
>>> +/*
>>> + * https://git.codelinaro.org/clo/la/kernel/msm-4.4/-/blame/caf_migration/kernel.lnx.4.4.r38-rel/arch/arm/boot/dts/qcom/msm8996-v3.dtsi#L403-414
>>> + */
>>
>> There is no need to add the link to downstream code in comments. Please remove them.
>
> They are needed somewhere, to double check the values.
> Otherwise, it's just voodoo programming.
>
> If not in the code, then maybe in the commit message?
>
> Since qcom doesn't publish datasheets, downstream code
> is the best we've got.
>
> Regards
>
Commit message is a good idea.
Do that.
---
bod
next prev parent reply other threads:[~2024-05-06 15:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 13:44 [PATCH v3 0/3] Add support for qcom msm8998-venus (HW vdec / venc) Marc Gonzalez
2024-05-06 13:45 ` [PATCH v3 1/3] dt-bindings: media: add qcom,msm8998-venus Marc Gonzalez
2024-05-06 13:46 ` [PATCH v3 2/3] arm64: dts: qcom: msm8998: add venus node Marc Gonzalez
2024-05-06 13:47 ` [PATCH v3 3/3] media: venus: add msm8998 support Marc Gonzalez
2024-05-06 14:43 ` Vikash Garodia
2024-05-06 14:51 ` Marc Gonzalez
2024-05-06 15:57 ` Bryan O'Donoghue [this message]
2024-05-07 9:06 ` Vikash Garodia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddd78134-6f04-4ef6-a3fa-4a2932d81165@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=andersson@kernel.org \
--cc=avrac@freebox.fr \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mgonzalez@freebox.fr \
--cc=phhusson@freebox.fr \
--cc=quic_jhugo@quicinc.com \
--cc=quic_vgarodia@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=stanimir.k.varbanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).