From: Vikash Garodia <quic_vgarodia@quicinc.com>
To: Marc Gonzalez <mgonzalez@freebox.fr>,
Bjorn Andersson <andersson@kernel.org>,
Jeffrey Hugo <quic_jhugo@quicinc.com>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Stanimir Varbanov <stanimir.k.varbanov@gmail.com>,
Bryan O Donoghue <bryan.odonoghue@linaro.org>
Cc: MSM <linux-arm-msm@vger.kernel.org>,
linux-media <linux-media@vger.kernel.org>,
DT <devicetree@vger.kernel.org>,
"Pierre-Hugues Husson" <phhusson@freebox.fr>,
Arnaud Vrac <avrac@freebox.fr>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH v4 3/3] media: venus: add msm8998 support
Date: Tue, 7 May 2024 19:47:55 +0530 [thread overview]
Message-ID: <d1d42534-2d0f-ccd8-1e1d-1a64a4947555@quicinc.com> (raw)
In-Reply-To: <6df495c5-db26-431d-8ce1-8263a2a12b2f@freebox.fr>
On 5/7/2024 3:00 PM, Marc Gonzalez wrote:
> From: Pierre-Hugues Husson <phhusson@freebox.fr>
>
> Add the missing bits for msm8998 support.
>
> Downstream vendor code for reference:
>
> https://git.codelinaro.org/clo/la/kernel/msm-4.4/-/blob/caf_migration/kernel.lnx.4.4.r38-rel/arch/arm/boot/dts/qcom/msm8998-vidc.dtsi#L42-53
>
> qcom,load-freq-tbl =
> /* Encoders */
> <972000 465000000 0x55555555>, /* 4k UHD @ 30 */
> <489600 360000000 0x55555555>, /* 1080p @ 60 */
> <244800 186000000 0x55555555>, /* 1080p @ 30 */
> <108000 100000000 0x55555555>, /* 720p @ 30 */
> /* Decoders */
> <1944000 465000000 0xffffffff>, /* 4k UHD @ 60 */
> < 972000 360000000 0xffffffff>, /* 4k UHD @ 30 */
> < 489600 186000000 0xffffffff>, /* 1080p @ 60 */
> < 244800 100000000 0xffffffff>; /* 1080p @ 30 */
>
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> Signed-off-by: Pierre-Hugues Husson <phhusson@freebox.fr>
> Signed-off-by: Marc Gonzalez <mgonzalez@freebox.fr>
> ---
> drivers/media/platform/qcom/venus/core.c | 39 +++++++++++++++++++++++++++++++++++++++
> 1 file changed, 39 insertions(+)
>
> diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
> index ce206b7097541..8b715cb7ab51a 100644
> --- a/drivers/media/platform/qcom/venus/core.c
> +++ b/drivers/media/platform/qcom/venus/core.c
> @@ -587,6 +587,44 @@ static const struct venus_resources msm8996_res = {
> .fwname = "qcom/venus-4.2/venus.mbn",
> };
>
> +static const struct freq_tbl msm8998_freq_table[] = {
> + { 1944000, 465000000 }, /* 4k UHD @ 60 (decode only) */
> + { 972000, 465000000 }, /* 4k UHD @ 30 */
> + { 489600, 360000000 }, /* 1080p @ 60 */
> + { 244800, 186000000 }, /* 1080p @ 30 */
> + { 108000, 100000000 }, /* 720p @ 30 */
> +};
> +
> +static const struct reg_val msm8998_reg_preset[] = {
> + { 0x80124, 0x00000003 },
> + { 0x80550, 0x01111111 },
> + { 0x80560, 0x01111111 },
> + { 0x80568, 0x01111111 },
> + { 0x80570, 0x01111111 },
> + { 0x80580, 0x01111111 },
> + { 0x80588, 0x01111111 },
> + { 0xe2010, 0x00000000 },
> +};
> +
> +static const struct venus_resources msm8998_res = {
> + .freq_tbl = msm8998_freq_table,
> + .freq_tbl_size = ARRAY_SIZE(msm8998_freq_table),
> + .reg_tbl = msm8998_reg_preset,
> + .reg_tbl_size = ARRAY_SIZE(msm8998_reg_preset),
> + .clks = { "core", "iface", "bus", "mbus" },
> + .clks_num = 4,
> + .vcodec0_clks = { "core" },
> + .vcodec1_clks = { "core" },
> + .vcodec_clks_num = 1,
> + .max_load = 2563200,
> + .hfi_version = HFI_VERSION_3XX,
> + .vmem_id = VIDC_RESOURCE_NONE,
> + .vmem_size = 0,
> + .vmem_addr = 0,
> + .dma_mask = 0xddc00000 - 1,
> + .fwname = "qcom/venus-4.4/venus.mbn",
> +};
> +
> static const struct freq_tbl sdm660_freq_table[] = {
> { 979200, 518400000 },
> { 489600, 441600000 },
> @@ -893,6 +931,7 @@ static const struct venus_resources sc7280_res = {
> static const struct of_device_id venus_dt_match[] = {
> { .compatible = "qcom,msm8916-venus", .data = &msm8916_res, },
> { .compatible = "qcom,msm8996-venus", .data = &msm8996_res, },
> + { .compatible = "qcom,msm8998-venus", .data = &msm8998_res, },
> { .compatible = "qcom,sdm660-venus", .data = &sdm660_res, },
> { .compatible = "qcom,sdm845-venus", .data = &sdm845_res, },
> { .compatible = "qcom,sdm845-venus-v2", .data = &sdm845_res_v2, },
Acked-by: Vikash Garodia <quic_vgarodia@quicinc.com>
Regards,
Vikash
next prev parent reply other threads:[~2024-05-07 14:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 9:27 [PATCH v4 0/3] Add support for qcom msm8998-venus (HW vdec / venc) Marc Gonzalez
2024-05-07 9:28 ` [PATCH v4 1/3] dt-bindings: media: add qcom,msm8998-venus Marc Gonzalez
2024-05-07 9:29 ` [PATCH v4 2/3] arm64: dts: qcom: msm8998: add venus node Marc Gonzalez
2024-05-07 14:20 ` Vikash Garodia
2024-05-13 8:51 ` Marc Gonzalez
2024-05-28 10:49 ` Marc Gonzalez
2024-05-28 11:51 ` Dmitry Baryshkov
2024-05-07 9:30 ` [PATCH v4 3/3] media: venus: add msm8998 support Marc Gonzalez
2024-05-07 14:17 ` Vikash Garodia [this message]
2024-05-28 12:52 ` Marc Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1d42534-2d0f-ccd8-1e1d-1a64a4947555@quicinc.com \
--to=quic_vgarodia@quicinc.com \
--cc=andersson@kernel.org \
--cc=avrac@freebox.fr \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mgonzalez@freebox.fr \
--cc=phhusson@freebox.fr \
--cc=quic_jhugo@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=stanimir.k.varbanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).