From: Marc Gonzalez <mgonzalez@freebox.fr>
To: Vikash Garodia <quic_vgarodia@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Jeffrey Hugo <quic_jhugo@quicinc.com>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Stanimir Varbanov <stanimir.k.varbanov@gmail.com>,
Bryan O Donoghue <bryan.odonoghue@linaro.org>
Cc: MSM <linux-arm-msm@vger.kernel.org>,
linux-media <linux-media@vger.kernel.org>,
DT <devicetree@vger.kernel.org>,
Pierre-Hugues Husson <phhusson@freebox.fr>,
Arnaud Vrac <avrac@freebox.fr>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH v2 3/3] media: venus: add msm8998 support
Date: Mon, 6 May 2024 15:18:29 +0200 [thread overview]
Message-ID: <c9418e9f-711f-42e4-8032-480d0f32dfe9@freebox.fr> (raw)
In-Reply-To: <3e522515-f7ba-461f-1af2-2e22b143981b@quicinc.com>
On 06/05/2024 14:19, Vikash Garodia wrote:
> On 4/30/2024 9:04 PM, Marc Gonzalez wrote:
>
>> From: Pierre-Hugues Husson <phhusson@freebox.fr>
>>
>> Add the missing bits for msm8998 support.
>>
>> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>> Signed-off-by: Pierre-Hugues Husson <phhusson@freebox.fr>
>> Signed-off-by: Marc Gonzalez <mgonzalez@freebox.fr>
>> ---
>> drivers/media/platform/qcom/venus/core.c | 42 ++++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 42 insertions(+)
>>
>> diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
>> index ce206b7097541..42e0c580e093d 100644
>> --- a/drivers/media/platform/qcom/venus/core.c
>> +++ b/drivers/media/platform/qcom/venus/core.c
>> @@ -587,6 +587,47 @@ static const struct venus_resources msm8996_res = {
>> .fwname = "qcom/venus-4.2/venus.mbn",
>> };
>>
>> +static const struct freq_tbl msm8998_freq_table[] = {
>> + { 1944000, 520000000 }, /* 4k UHD @ 60 (decode only) */
>> + { 972000, 520000000 }, /* 4k UHD @ 30 */
>> + { 489600, 346666667 }, /* 1080p @ 60 */
>> + { 244800, 150000000 }, /* 1080p @ 30 */
>> + { 108000, 75000000 }, /* 720p @ 30 */
>> +};
>
> Can we reuse the table from 8996 since they are exactly same ?
Now that I have squinted closer at the downstream code,
I see that the tables should actually be different...
Will spin a v3.
Regards
next prev parent reply other threads:[~2024-05-06 13:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 15:28 [PATCH v2 0/3] Add support for qcom msm8998-venus (HW vdec / venc) Marc Gonzalez
2024-04-30 15:30 ` [PATCH v2 1/3] dt-bindings: media: add qcom,msm8998-venus Marc Gonzalez
2024-04-30 16:13 ` Bryan O'Donoghue
2024-04-30 16:37 ` Krzysztof Kozlowski
2024-04-30 15:32 ` [PATCH v2 2/3] arm64: dts: qcom: msm8998: add venus node Marc Gonzalez
2024-04-30 15:34 ` [PATCH v2 3/3] media: venus: add msm8998 support Marc Gonzalez
2024-05-06 12:19 ` Vikash Garodia
2024-05-06 13:18 ` Marc Gonzalez [this message]
2024-05-06 9:57 ` [PATCH v2 0/3] Add support for qcom msm8998-venus (HW vdec / venc) Marc Gonzalez
2024-05-06 10:25 ` Bryan O'Donoghue
2024-05-06 12:22 ` Vikash Garodia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9418e9f-711f-42e4-8032-480d0f32dfe9@freebox.fr \
--to=mgonzalez@freebox.fr \
--cc=andersson@kernel.org \
--cc=avrac@freebox.fr \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=phhusson@freebox.fr \
--cc=quic_jhugo@quicinc.com \
--cc=quic_vgarodia@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=stanimir.k.varbanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).