From: Hans Verkuil <hverkuil@xs4all.nl>
To: Sakari Ailus <sakari.ailus@linux.intel.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-media@vger.kernel.org, Wentong Wu <wentong.wu@intel.com>
Subject: Re: [PATCH v2 0/3] Use INTEGER64 type for MEI CSI LINK_FREQ control
Date: Mon, 29 Apr 2024 09:30:37 +0200 [thread overview]
Message-ID: <c0ae16a7-a817-4c43-bfb8-f71da01e0713@xs4all.nl> (raw)
In-Reply-To: <Zi9MLcZzS4xW1tyU@kekkonen.localdomain>
On 29/04/2024 09:28, Sakari Ailus wrote:
> Hi Laurent,
>
> On Mon, Apr 29, 2024 at 02:20:28AM +0300, Laurent Pinchart wrote:
>> Hi Sakari,
>>
>> Thank you for the patches.
>>
>> On Fri, Apr 26, 2024 at 05:55:35PM +0300, Sakari Ailus wrote:
>>> Hi folks,
>>>
>>> An integer menu isn't a useful control type for conveying the frequency
>>> depending on an external device to the receiver. Instead, in the MEI CSI
>>> driver, just obtain the link frequency from the upsteam sub-device and
>>> pass it on to the receiver.
>>>
>>> The v4l2_get_link_freq() is changed to add support for this and it's
>>> documented as well.
>>
>> Using a control for this seems to be a bit of a hack :-S Wouldn't it fit
>> more nicely in the .get_mbus_config() operation ? That would avoid
>> exposing this to userspace, and would also have the nice advantage that
>> the value could be queried per pad.
>
> Works for me. I also think it's better than using a new control for this
> actually.
Same for me. As you gathered, I was not very enthusiastic about using a
control for this either.
Regards,
Hans
>
>>
>>> since v1:
>>>
>>> - Add a new 64-bit integer control V4L2_CID_CUR_LINK_FREQ instead of
>>> re-using V4L2_CID_LINK_FREQ.
>>>
>>> Sakari Ailus (3):
>>> media: Documentation: v4l: Add CUR_LINK_FREQ control
>>> media: v4l: Support obtaining link frequency from CUR_LINK_FREQ
>>> control
>>> media: ivsc: csi: Fix link frequency control behaviour
>>>
>>> .../media/v4l/ext-ctrls-image-process.rst | 4 ++++
>>> drivers/media/pci/intel/ivsc/mei_csi.c | 24 ++++++-------------
>>> drivers/media/v4l2-core/v4l2-common.c | 6 ++++-
>>> drivers/media/v4l2-core/v4l2-ctrls-defs.c | 5 ++++
>>> include/uapi/linux/v4l2-controls.h | 1 +
>>> 5 files changed, 22 insertions(+), 18 deletions(-)
>>>
>>>
>>> base-commit: 6612d1ae37b52d37d1d515d7c5110b9f3afe94d2
>>
>
next prev parent reply other threads:[~2024-04-29 7:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 14:55 [PATCH v2 0/3] Use INTEGER64 type for MEI CSI LINK_FREQ control Sakari Ailus
2024-04-26 14:55 ` [PATCH v2 1/3] media: Documentation: v4l: Add CUR_LINK_FREQ control Sakari Ailus
2024-04-26 14:55 ` [PATCH v2 2/3] media: v4l: Support obtaining link frequency from " Sakari Ailus
2024-04-26 14:55 ` [PATCH v2 3/3] media: ivsc: csi: Fix link frequency control behaviour Sakari Ailus
2024-04-28 3:22 ` Wu, Wentong
2024-04-28 23:20 ` [PATCH v2 0/3] Use INTEGER64 type for MEI CSI LINK_FREQ control Laurent Pinchart
2024-04-29 7:28 ` Sakari Ailus
2024-04-29 7:30 ` Hans Verkuil [this message]
2024-04-29 7:50 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0ae16a7-a817-4c43-bfb8-f71da01e0713@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=wentong.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).